From: Josh Kunz <jkz@google.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
armbru@redhat.com
Subject: Re: [PATCH 2/4] linux-user: Use `qemu_log' for strace
Date: Fri, 17 Jan 2020 11:28:33 -0800 [thread overview]
Message-ID: <CADgy-2vbY9UPfZ4V474J1g4LtwxrjfQ1JQ17rpJ97puC-kyHsw@mail.gmail.com> (raw)
In-Reply-To: <87muaqmhmq.fsf@linaro.org>
On Tue, Jan 14, 2020 at 2:56 AM Alex Bennée <alex.bennee@linaro.org> wrote:
> Could we cut out the middle-man and just qemu_add_log(LOG_STRACE) here
> and drop the enable_strace variable.
This code has been re-factored based on Laurent's comments. In v2
`enable_strace` is still needed to avoid QEMU_LOG/-d overwriting the
mask set by -strace.
> Please don't drop the brace - c.f. CODING_STYLE.rst
Thanks for the catch!
> Side note, print_taken_signal might want to consider using the
> qemu_log_lock() functionality to keep sequential qemu_log's together. I
> suspect you might want to do the same for syscalls.
This is likely true, but outside the scope of this patch (this patch
preserves the current bad behavior). When I get some spare time I'll
try and address this in a follow up patch series.
next prev parent reply other threads:[~2020-01-17 19:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 3:01 [PATCH 0/4] migration: Replace gemu_log with qemu_log Josh Kunz
2020-01-14 3:01 ` [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging Josh Kunz
2020-01-14 8:28 ` Laurent Vivier
2020-01-14 8:30 ` Laurent Vivier
2020-01-14 10:42 ` Alex Bennée
2020-01-17 19:28 ` Josh Kunz
2020-01-14 3:01 ` [PATCH 2/4] linux-user: Use `qemu_log' for strace Josh Kunz
2020-01-14 9:09 ` Laurent Vivier
2020-01-14 16:15 ` Paolo Bonzini
2020-01-17 19:28 ` Josh Kunz
2020-01-14 10:55 ` Alex Bennée
2020-01-17 19:28 ` Josh Kunz [this message]
2020-01-14 3:01 ` [PATCH 3/4] linux-user: remove gemu_log from the linux-user tree Josh Kunz
2020-01-14 10:56 ` Alex Bennée
2020-01-14 3:01 ` [PATCH 4/4] bsd-user: Replace gemu_log with qemu_log Josh Kunz
2020-01-14 3:06 ` [PATCH 0/4] migration: " Warner Losh
2020-01-16 23:13 ` Josh Kunz
2020-01-14 11:02 ` Alex Bennée
2020-01-16 23:12 ` Josh Kunz
2020-01-20 11:36 ` Alex Bennée
2020-02-04 2:55 ` Josh Kunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADgy-2vbY9UPfZ4V474J1g4LtwxrjfQ1JQ17rpJ97puC-kyHsw@mail.gmail.com \
--to=jkz@google.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).