Re: [PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet

[Lirong Yuan <yuanzi@google.com>]

On Mon, Aug 3, 2020 at 4:27 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Lirong Yuan <yuanzi@google.com> writes:
>
> > This allows gdb to access the target’s auxiliary vector,
> > which can be helpful for telling system libraries important details
> > about the hardware, operating system, and process.
> >
> > Signed-off-by: Lirong Yuan <yuanzi@google.com>
>
> I cleaned up the test a little:
>
> modified   tests/tcg/multiarch/gdbstub/test-qxfer-auxv-read.py
> @@ -22,13 +22,9 @@ def report(cond, msg):
>  def run_test():
>      "Run through the tests one by one"
>
> -    cond = True
> -    try:
> -      gdb.execute("info auxv")
> -    except (gdb.error, AttributeError):
> -      cond = False
> -
> -    report(cond, "Display the auxiliary vector of the inferior.")
> +    auxv = gdb.execute("info auxv", False, True)
> +    report(isinstance(auxv, str), "Fetched auxv from inferior")
> +    report(auxv.find("sha1"), "Found test binary name in auxv")
>
>  #
>  # This runs as the script it sourced (via -x, via run-test.py)
>
>
> Queued to gdbstub/next, thanks.
>
> --
> Alex Bennée

Awesome, thank you Alex for the review and cleanup!

Regards,
Lirong