From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6FAC433DB for ; Wed, 13 Jan 2021 13:30:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B13BD221F1 for ; Wed, 13 Jan 2021 13:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B13BD221F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzgEF-0002Nz-Gs for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 08:30:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzgBv-0001Av-Fb; Wed, 13 Jan 2021 08:28:03 -0500 Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]:37394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzgBt-00046s-6p; Wed, 13 Jan 2021 08:28:03 -0500 Received: by mail-yb1-xb30.google.com with SMTP id z1so2150848ybr.4; Wed, 13 Jan 2021 05:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GsOJlZDnOmaLHm617iqZrqPSsYXYDwDHCB+ZhkydkIU=; b=duqbQgJywsdK6PGXC8LkIQ2sblz2UdLXIAMCNx3LTgdxxtHW8Tr2DIWtRRYsoXW8ex Rk070r2rxnZKFg5RJPuOG2gHP2uovFsB0rrIPR2UjeIU6vnEFgd4Dw7N31iXokH0FB3h xU4KIt/rlmwH4e69xwQbB/PyHnwhkxL/4JLUFZrAsvrqdzYxwDT3nFRLwQEQmhBOA7Lb GzNk3xZ7fqnJ+koG2awBCaoh9hfw372BTQ5RTELzmcipdhxZG5doF1/1QuGejok1PbkH GYEAZKt/+1sNFAVDAtCRR2fgFlgNjVndwJtTlNoKGZ0PE9dNaacs48/EYibFaNutgIyi eRnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GsOJlZDnOmaLHm617iqZrqPSsYXYDwDHCB+ZhkydkIU=; b=ZB+T2vndPIQ33DBNnA6EBVtiMO2nDQ097u4aGF2u7z2LAjv/lU62hnLy/977Bq8nnt 9HoTkuZGPc7WP9tjfaAoBQeZjgjTZD5/69cqX060Kydn7rORE7ld4IdGs/zYyngXU46C imq/IgGLD+hrKQ4y+7YfzB0qS1xYm6+fs2C5v55e1JqWov8CRaC8HIUXOVCPMsR5WC8p 6mKkupddZ1KrbRdS0Bm4AUXNIYxzwzMAomo1UBKygV6tdG57WmwycwHUxD+rt9fNgtOc ycotChnlwZoKhKdISWwg80Op8L35XXwkB8Mf3NLr0mOf7HL54QnKgHa3kfDaIode+bab gsXg== X-Gm-Message-State: AOAM533ldSMzPPq0LtSorR6nFj4O3NSaFB3tN9Ehng01gUm1cxnYkxPd TwO+K+PMbPlJm1Lc6ktXeR5VJ7bsL0gN999IlzY= X-Google-Smtp-Source: ABdhPJxVgTgwprohUW1/gVUjhfCbS1cXOV+QRMeqkLuv1ynJ4kIMCKkE4MBuTtK6azc37eXV1qjFgytZRH7lozeMVXc= X-Received: by 2002:a25:5a43:: with SMTP id o64mr3407039ybb.387.1610544479772; Wed, 13 Jan 2021 05:27:59 -0800 (PST) MIME-Version: 1.0 References: <20210112183529.2011863-1-f4bug@amsat.org> <74a2566b-cd32-743f-8088-c59e992be755@amsat.org> In-Reply-To: <74a2566b-cd32-743f-8088-c59e992be755@amsat.org> From: Bin Meng Date: Wed, 13 Jan 2021 21:27:48 +0800 Message-ID: Subject: Re: [RFC PATCH v6 00/11] hw/ssi: imx_spi: Fix various bugs in the imx_spi model To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Alistair Francis , Xuzhou Cheng , Bin Meng , "qemu-devel@nongnu.org Developers" , Jean-Christophe Dubois , qemu-arm , Peter Chubb Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Philippe, On Wed, Jan 13, 2021 at 3:53 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Hi Ben, > > On 1/13/21 4:29 AM, Bin Meng wrote: > > On Wed, Jan 13, 2021 at 2:35 AM Philippe Mathieu-Daud=C3=A9 wrote: > >> > >> Hi, > >> > >> As it is sometimes harder for me to express myself in plain > >> English, I found it easier to write the patches I was thinking > >> about. I know this doesn't scale. > >> > >> So this is how I understand the ecSPI reset works, after > >> looking at the IMX6DQRM.pdf datasheet. > >> > >> This is a respin of Ben's v5 series [*]. > >> Tagged RFC because I have not tested it :) > > > > Unfortunately this series breaks SPI flash testing under both U-Boot > > and VxWorks 7. > > Thanks for testing :) Can you provide the binary tested and the command > line used? At least one, so I can have a look. Sure, will send you offline. > > >> Sometimes changing device reset to better match hardware gives > >> trouble when using '-kernel ...' because there is no bootloader > >> setting the device in the state Linux expects it. > >> > > > > Given most of the new changes in this RFC series are clean-ups, I > > suggest we apply the v5 series unless there is anything seriously > > wrong in v5, IOW, don't fix it unless it's broken. > > > > Thoughts? > > Up to the maintainer :) > > The IMX6DQRM datasheet is available here: > https://community.nxp.com/t5/i-MX-Processors-Knowledge-Base/i-MX-6DQ-Refe= rence-Manual-IMX6DQRM-R2-Part-1/ta-p/1115983 > https://community.nxp.com/t5/i-MX-Processors-Knowledge-Base/i-MX-6DQ-Refe= rence-Manual-IMX6DQRM-R2-Part-2/ta-p/1118510 Regards, Bin