From: Bin Meng <bmeng.cn@gmail.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Dylan Jhong <dylan@andestech.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"Alan Quey-Liang Kao\(\(\(\(\(\(\(\(\(\(\)"
<alankao@andestech.com>, wangjunqiang <wangjunqiang@iscas.ac.cn>,
Bin Meng <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Ruinland Chuan-Tzu Tsai <ruinland@andestech.com>
Subject: Re: [PATCH V2 0/2] Proposing custom CSR handling logic
Date: Wed, 12 May 2021 22:47:02 +0800 [thread overview]
Message-ID: <CAEUhbmUZi17xzoSU9jwJubeqwi+gzXQ0p6kSDY2T579wCdQopg@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKO35O+bichwKQVeZ2tPT+2G-hweds1VY6oJc_bqkuG8Zw@mail.gmail.com>
On Wed, May 12, 2021 at 2:03 PM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Tue, May 11, 2021 at 8:07 PM Ruinland Chuan-Tzu Tsai
> <ruinland@andestech.com> wrote:
> >
> > Hi all,
> >
> > My sincere apology that I missed the patch to include our own CSR table
> > into the patch series and there were plenty of typos.
> > Thus I'm sending out V2 of these tiny patches.
> >
> > I agree with Alistair's comment on not introducing intrusive code which
> > will interfere the generic code structure. Yet since there are
> > possibilities that some custom CSRs/instructions could be once drafted/
> > proposed by vendors at first, and made themselves into the standard
> > as the implementation become widely adopted.
> >
> > So in this patch set, we humbly utilzed a glib hash table for inserting
> > the `struct riscv_custom_csr_operations`, check if the CSR is a non
> > standard one, and then proceed the desired behavior.
> >
> > Once the non-standard CSRs make themselves into the specification,
> > people could easily plug-and-use the code into CSR operation table
> > inside `csr.c`.
> >
> > Ones may have concerns regarding the check code would introduce
> > further overhead. For those considerations, I guess it could be solved
> > by introducing a build option such as '--enable-riscv-vendor-features'
> > to toggle the code.
> >
> > Cordially yours,
> > Ruinland ChuanTzu Tsai
> >
> > Ruinland Chuan-Tzu Tsai (2):
> > Adding premliminary support for custom CSR handling mechanism
> > Adding custom Andes CSR table.
>
> Thanks for the patches.
>
> Can you please include:
> wangjunqiang@iscas.ac.cn
> qemu-devel@nongnu.org
> bin.meng@windriver.com
>
> on future patches so everyone is included.
Thanks Alistair!
>
> >
> > target/riscv/cpu.c | 28 ++++++++
> > target/riscv/cpu.h | 12 +++-
> > target/riscv/cpu_bits.h | 115 ++++++++++++++++++++++++++++++++
> > target/riscv/csr.c | 107 ++++++++++++++++++++++++++++--
> > target/riscv/csr_andes.inc.c | 125 +++++++++++++++++++++++++++++++++++
> > 5 files changed, 381 insertions(+), 6 deletions(-)
I didn't see the original patch set in the ML, nor does it show up on
patchwork. I wonder is it posted on the ML?
Regards,
Bin
next prev parent reply other threads:[~2021-05-12 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210511100722.18065-1-ruinland@andestech.com>
2021-05-12 6:03 ` [PATCH V2 0/2] Proposing custom CSR handling logic Alistair Francis
2021-05-12 14:47 ` Bin Meng [this message]
2021-05-12 23:40 ` Alistair Francis
[not found] ` <20210511100722.18065-2-ruinland@andestech.com>
[not found] ` <CAKmqyKP1O0LNGX-u1UkR6uke5N0h+T5vS=7DmZ947KLsCOnv=Q@mail.gmail.com>
2021-05-12 23:41 ` [PATCH V2 1/2] Adding premliminary support for custom CSR handling mechanism Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmUZi17xzoSU9jwJubeqwi+gzXQ0p6kSDY2T579wCdQopg@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=alankao@andestech.com \
--cc=alistair23@gmail.com \
--cc=bin.meng@windriver.com \
--cc=dylan@andestech.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=ruinland@andestech.com \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).