From: Bin Meng <bmeng.cn@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Jason Wang <jasowang@redhat.com>,
qemu-arm@nongnu.org,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] hw: net: cadence_gem: Fix build errors in DB_PRINT()
Date: Thu, 8 Aug 2019 12:45:21 +0800 [thread overview]
Message-ID: <CAEUhbmV10=Diih7Cy7c1GweA8FeMhLaKUa6PXpSj8wy2Yn_Rww@mail.gmail.com> (raw)
In-Reply-To: <20190806105739.ypoa545l4vigsscg@steredhat>
On Tue, Aug 6, 2019 at 6:57 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Mon, Aug 05, 2019 at 08:52:54AM -0700, Bin Meng wrote:
> > When CADENCE_GEM_ERR_DEBUG is turned on, there are several
> > compilation errors in DB_PRINT(). Fix them.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> > hw/net/cadence_gem.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> > index d412085..7516e8f 100644
> > --- a/hw/net/cadence_gem.c
> > +++ b/hw/net/cadence_gem.c
> > @@ -983,8 +983,9 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
> > return -1;
> > }
> >
> > - DB_PRINT("copy %d bytes to 0x%x\n", MIN(bytes_to_copy, rxbufsize),
> > - rx_desc_get_buffer(s->rx_desc[q]));
> > + DB_PRINT("copy %d bytes to " TARGET_FMT_plx "\n",
> > + MIN(bytes_to_copy, rxbufsize),
> > + rx_desc_get_buffer(s, s->rx_desc[q]));
> >
> > /* Copy packet data to emulated DMA buffer */
> > address_space_write(&s->dma_as, rx_desc_get_buffer(s, s->rx_desc[q]) +
> > @@ -1157,7 +1158,7 @@ static void gem_transmit(CadenceGEMState *s)
> > if (tx_desc_get_length(desc) > sizeof(tx_packet) -
> > (p - tx_packet)) {
> > DB_PRINT("TX descriptor @ 0x%x too large: size 0x%x space " \
> > - "0x%x\n", (unsigned)packet_desc_addr,
> > + "0x%lx\n", (unsigned)packet_desc_addr,
>
> What about using 'z' modifier? I mean "0x%zx" to print sizeof(..).
Yes, good idea. Will do in v2. Thanks!
Regards,
Bin
next prev parent reply other threads:[~2019-08-08 4:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 15:52 [Qemu-devel] [PATCH] hw: net: cadence_gem: Fix build errors in DB_PRINT() Bin Meng
2019-08-06 10:57 ` Stefano Garzarella
2019-08-08 4:45 ` Bin Meng [this message]
2019-08-08 4:44 ` [Qemu-devel] [PATCH v2] " Bin Meng
2019-08-08 5:21 ` Philippe Mathieu-Daudé
2019-08-08 6:36 ` Bin Meng
2019-08-08 7:01 ` Philippe Mathieu-Daudé
2019-08-08 7:18 ` Bin Meng
2019-08-08 9:08 ` [Qemu-devel] [Qemu-arm] " Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUhbmV10=Diih7Cy7c1GweA8FeMhLaKUa6PXpSj8wy2Yn_Rww@mail.gmail.com' \
--to=bmeng.cn@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).