From: Bin Meng <bmeng.cn@gmail.com> To: Bug 1815721 <1815721@bugs.launchpad.net> Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org> Subject: Re: [Bug 1815721] Re: RISC-V PLIC enable interrupt for multicore Date: Tue, 24 Mar 2020 18:35:08 +0800 [thread overview] Message-ID: <CAEUhbmV8YECctHEnLACq_aD9JwqLpMixPAvC=UGFNwJKrb9_tA@mail.gmail.com> (raw) In-Reply-To: <158503767628.19604.846014029546093014.malone@wampee.canonical.com> On Tue, Mar 24, 2020 at 4:20 PM RTOS Pharos <1815721@bugs.launchpad.net> wrote: > > Hi, > > After some debugging (and luck), the problem (at least in the Virt > board) was that the PLIC code inside QEMU addresses the core x 2 instead > of just the core (core=hart). That is why it worked for core 0 (0x2 = 0) > but for core 1 it has to address the PLIC memory area for core 2. > > For example, the interrupt enable address for core 1 starts at offset > 0x002080 (see https://github.com/riscv/riscv-plic-spec/blob/master > /riscv-plic.adoc) but we actually have to change the enable bit for core > 2 (at 0x002100) to make to work for core 1. https://github.com/riscv/riscv-plic-spec/blob/master/riscv-plic.adoc says: "base + 0x002080: Enable bits for sources 0-31 on context 1" This is context 1, not core 1. It looks to me you were running an image built for SiFive FU540. Please test your image against "sifive_u" machine instead. > > The same is true for the priority threshold and claim complete registers > (we need to multiply the core by 2) > > Either the documentation at https://github.com/riscv/riscv-plic- > spec/blob/master/riscv-plic.adoc does not have the correct memory > addresses for qemu virt board, or qemu appears to be wrong. > > -- Regards, Bin
WARNING: multiple messages have this Message-ID (diff)
From: Bin Meng <bmeng.cn@gmail.com> To: qemu-devel@nongnu.org Subject: Re: [Bug 1815721] Re: RISC-V PLIC enable interrupt for multicore Date: Tue, 24 Mar 2020 10:35:08 -0000 [thread overview] Message-ID: <CAEUhbmV8YECctHEnLACq_aD9JwqLpMixPAvC=UGFNwJKrb9_tA@mail.gmail.com> (raw) Message-ID: <20200324103508.rqGDb4d0qRSF_MWXWZ5BsULaLjl83UuPzW9B5usEh1Q@z> (raw) In-Reply-To: 158503767628.19604.846014029546093014.malone@wampee.canonical.com On Tue, Mar 24, 2020 at 4:20 PM RTOS Pharos <1815721@bugs.launchpad.net> wrote: > > Hi, > > After some debugging (and luck), the problem (at least in the Virt > board) was that the PLIC code inside QEMU addresses the core x 2 instead > of just the core (core=hart). That is why it worked for core 0 (0x2 = 0) > but for core 1 it has to address the PLIC memory area for core 2. > > For example, the interrupt enable address for core 1 starts at offset > 0x002080 (see https://github.com/riscv/riscv-plic-spec/blob/master > /riscv-plic.adoc) but we actually have to change the enable bit for core > 2 (at 0x002100) to make to work for core 1. https://github.com/riscv/riscv-plic-spec/blob/master/riscv-plic.adoc says: "base + 0x002080: Enable bits for sources 0-31 on context 1" This is context 1, not core 1. It looks to me you were running an image built for SiFive FU540. Please test your image against "sifive_u" machine instead. > > The same is true for the priority threshold and claim complete registers > (we need to multiply the core by 2) > > Either the documentation at https://github.com/riscv/riscv-plic- > spec/blob/master/riscv-plic.adoc does not have the correct memory > addresses for qemu virt board, or qemu appears to be wrong. > > -- Regards, Bin -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815721 Title: RISC-V PLIC enable interrupt for multicore Status in QEMU: New Bug description: Hello all, There is a bug in Qemu related to the enabling of external interrupts for multicores (Virt machine). After correcting Qemu as described in #1815078 (https://bugs.launchpad.net/qemu/+bug/1815078), when we try to enable interrupts for core 1 at address 0x0C00_2080 we don't seem to be able to trigger an external interrupt (e.g. UART0). This works perfectly for core 0, but fore core 1 it does not work at all. I assume that given bug #1815078 does not enable any external interrupt then this feature has not been tested. I tried to look at the qemu source code but with no luck so far. I guess the problem is related to function parse_hart_config (in sfive_plic.c) that initializes incorrectly the plic->addr_config[addrid].hartid, which is later on read in sifive_plic_update. But this is a guess. Best regards, Pharos team To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1815721/+subscriptions
next prev parent reply other threads:[~2020-03-24 10:36 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-13 7:37 [Qemu-devel] [Bug 1815721] [NEW] RISC-V PLIC enable interrupt for multicore RTOS Pharos 2020-03-24 8:14 ` [Bug 1815721] " RTOS Pharos 2020-03-24 10:35 ` Bin Meng [this message] 2020-03-24 10:35 ` Bin Meng 2020-03-25 17:04 ` RTOS Pharos 2020-09-28 7:15 ` Teodori Serge 2020-11-19 20:24 ` Alistair Francis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAEUhbmV8YECctHEnLACq_aD9JwqLpMixPAvC=UGFNwJKrb9_tA@mail.gmail.com' \ --to=bmeng.cn@gmail.com \ --cc=1815721@bugs.launchpad.net \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).