From: Bin Meng <bmeng.cn@gmail.com>
To: Jason Wang <jasowang@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 2/3] hw/net: e1000e: Correct the initial value of VET register
Date: Fri, 30 Jul 2021 09:21:12 +0800 [thread overview]
Message-ID: <CAEUhbmVcAj+Je=ynuPCaOLwsgq6a-XhTEk3KTH=AJFEnXCcPhg@mail.gmail.com> (raw)
In-Reply-To: <20210723075512.84897-2-bmeng.cn@gmail.com>
Hi Jason,
On Fri, Jul 23, 2021 at 3:55 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Christina Wang <christina.wang@windriver.com>
>
> The initial value of VLAN Ether Type (VET) register is 0x8100, as per
> the manual and real hardware.
>
> While Linux e1000e driver always writes VET register to 0x8100, it is
> not always the case for everyone. Drivers relying on the reset value
> of VET won't be able to transmit and receive VLAN frames in QEMU.
>
> Unlike e1000 in QEMU, e1000e uses a field 'vet' in "struct E1000Core"
> to cache the value of VET register, but the cache only gets updated
> when VET register is written. To always get a consistent VET value
> no matter VET is written or remains its reset value, drop the 'vet'
> field and use 'core->mac[VET]' directly.
>
> Reported-by: Markus Carlstedt <markus.carlstedt@windriver.com>
> Signed-off-by: Christina Wang <christina.wang@windriver.com>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> ---
>
> Changes in v4:
> - Only keep hw_compat_6_0[] changes
>
> Changes in v3:
> - add a "init-vet" property for versioned machines
>
> Changes in v2:
> - keep the 'vet' field in "struct E1000Core" for migration compatibility
>
> hw/core/machine.c | 1 +
> hw/net/e1000e.c | 8 +++++++-
> hw/net/e1000e_core.c | 9 ++++-----
> 3 files changed, 12 insertions(+), 6 deletions(-)
>
Will this series be in 6.1?
Regards,
Bin
next prev parent reply other threads:[~2021-07-30 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 7:55 [PATCH v4 1/3] hw/net: e1000: Correct the initial value of VET register Bin Meng
2021-07-23 7:55 ` [PATCH v4 2/3] hw/net: e1000e: " Bin Meng
2021-07-30 1:21 ` Bin Meng [this message]
2021-08-02 4:05 ` Jason Wang
2021-07-23 7:55 ` [PATCH v4 3/3] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUhbmVcAj+Je=ynuPCaOLwsgq6a-XhTEk3KTH=AJFEnXCcPhg@mail.gmail.com' \
--to=bmeng.cn@gmail.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).