From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C0EC32751 for ; Thu, 8 Aug 2019 01:50:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA364217F5 for ; Thu, 8 Aug 2019 01:50:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WwBaaAGi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA364217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvXZH-0007Ec-Rn for qemu-devel@archiver.kernel.org; Wed, 07 Aug 2019 21:50:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51112) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvXYp-0006Wk-Ny for qemu-devel@nongnu.org; Wed, 07 Aug 2019 21:49:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvXYo-0006GT-OZ for qemu-devel@nongnu.org; Wed, 07 Aug 2019 21:49:47 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:37563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvXYo-0006GB-IU; Wed, 07 Aug 2019 21:49:46 -0400 Received: by mail-ed1-x544.google.com with SMTP id w13so88544763eds.4; Wed, 07 Aug 2019 18:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J7ISMZ0v61lDO7u7LIiTD5traq8L9JDwd8ZcKfq0ZvA=; b=WwBaaAGipJN9VaDjvJxucrLCnBzAftGJCKvhiYKULE7CK8UA9c28ovIDWkw9OWkgME rmAOtPMR3SuhN1DXUNP30rar+ue/tvHerxUTvcw1QJjDq3mxrebg9IO5QXfDLYhp9BWQ BuIFFs1Tak6b1SvEFJErx/ep+kvUPxwat8j6EaVb1UvD6QhtOrxgTj4kBERkx7PmVZsq PB+Rg+FA4Tpn9SJCr8x2ia0xrkD4+SfVMH1Mtrw47pYPfH6e50g4w6FNnhrj2PZxmNo6 g84AhNQHAqDZcdBPIpHgnz1Wt9f03a8l1KyntNcczMh3CrIhYcXzyYDuKk4fPd5SQTtY dqYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J7ISMZ0v61lDO7u7LIiTD5traq8L9JDwd8ZcKfq0ZvA=; b=j+RBgd1qSUv4feY2i5dsZ1hM0cKlTtger3yRgZRMM+YQk/764OrWV7AqHsRbfwTkFf wUO8FH6O5w5HjThd0ouXAFpuOAvnxm18fTMN0d+WORJ7FmVjqkgeKHoPwQGFW6NUgKoa YpQ3TXjaa1s9Y2UjQDPaHkPjmh+kmfAfrLedkAzLod9A+2urEOIIeaW2nu+Xwgy0nSYI Wdb8Q9PKC3cbERkGwruibN1WgfmS61yqp9f1b65Fo/wA7DkL2XKNZ9ETfjqVUF0UljBt rAKU1iXIzB/DilM9+TPGZRwg36pUvNbiu+ZF4/IF0pmWfRNNX1JPDP1EM2HmlQ058nPi 01jQ== X-Gm-Message-State: APjAAAUxo3SiMl4M6wGsxgsjixJ09Lem498GnAgkGgqadq0CO8Wp7NlZ eRnELRuM3+5YFUx/YtlhoASpnuOUXqe0mu1tcPE= X-Google-Smtp-Source: APXvYqwccFEwgrTaLcPG9Yk7YYyyeoxlavRQE6Iiq0Efoysosu+YfhI44WubRhYxmQyVX/VIL4qPRSQQQS5j+BdLQSc= X-Received: by 2002:a17:906:340e:: with SMTP id c14mr11306605ejb.170.1565228985039; Wed, 07 Aug 2019 18:49:45 -0700 (PDT) MIME-Version: 1.0 References: <1564577101-29020-1-git-send-email-bmeng.cn@gmail.com> <581a0284-c658-265f-1b0f-6f4be5406cee@linaro.org> In-Reply-To: From: Bin Meng Date: Thu, 8 Aug 2019 09:49:34 +0800 Message-ID: To: Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 Subject: Re: [Qemu-devel] [PATCH] riscv: rv32: Root page table address can be larger than 32-bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU riscv , Sagar Karandikar , Bastian Koppelmann , Richard Henderson , QEMU devel , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Palmer, On Thu, Aug 8, 2019 at 4:55 AM Palmer Dabbelt wrote: > > On Thu, Aug 1, 2019 at 7:58 AM Bin Meng wrote: >> >> On Thu, Aug 1, 2019 at 10:16 PM Richard Henderson >> wrote: >> > >> > On 7/31/19 6:53 PM, Bin Meng wrote: >> > > I am not sure how (idx * ptesize) could overflow. It represents the >> > > offset by a page table which is [0, 4096). >> > >> > You're right, I mis-read what was going on there. >> > >> > However, lower down, "target_ulong ppn" needs to be promoted to hwaddr, so that >> > >> > ppn = pte >> PTE_PPN_SHIFT; >> > ... >> > base = ppn << PGSHIFT; >> > >> > does not overflow. (Which is the part of the page table walk that I thought I >> > had gleaned from the patch without actually reading the entire function.) >> >> Ah, yes. ppn should be promoted. Thanks for the review! > > > Did I miss a v2? No, I will send a v2 soon. Regards, Bin