From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3123BC433DB for ; Wed, 13 Jan 2021 03:29:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A722122EBE for ; Wed, 13 Jan 2021 03:29:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A722122EBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzWr1-0006tZ-K7 for qemu-devel@archiver.kernel.org; Tue, 12 Jan 2021 22:29:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzWqQ-0006NS-Ad; Tue, 12 Jan 2021 22:29:14 -0500 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]:43972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzWqO-0007aD-NU; Tue, 12 Jan 2021 22:29:14 -0500 Received: by mail-yb1-xb2e.google.com with SMTP id y128so827097ybf.10; Tue, 12 Jan 2021 19:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=L/xGhiAffFRK5UXRDej83VHjRmbOO4At1tkENfozVQk=; b=fsH/qh8RdZzXz7BWQMr0QUHUmPtu0EV8t3JzaGrcjsbewLvZzc3kLSO1e5Xg+FqhXI XSmFND5fFMMIMEcTwBzTYBmCAZYnWY21VqyIDpseQoOFLp8VFOkGdL82MmfK8IKOs8iW gv3fwwULgZgcz7dxVeJplMgORozW/px3+WxglkhD6N0NUg4M40DDjxXXIc6J9X7pkniv lbt60PUZdXxh+6PtDNHFDWdX8sDaZMtzQYKxENS5VWM/FkzlRiflqN3F7Uo2laiN1XTM j+oMVAEQcvX78kHA/orN+vQ+P5zDouEnus7d7geLv0HagD/bphshD5fl8MMS9MFFa9S2 5uXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=L/xGhiAffFRK5UXRDej83VHjRmbOO4At1tkENfozVQk=; b=nbCaX32L5dMK0z1c17MJE+2lh+f6rRp3mWvcjGVrW/Tz0TsvsZmJ4c+e8JASwG3qYN vQwzAt85Ok7/DE+XW15xbEOAJQZi3Rt3j6IVHoZ0s0AIG/FmKyxTZDFbMlbFUMGMsW4Y NJniJBw1EHfkaHXj5xZl/cl/6Y2bJL7KRP1aAv7geHfnqjeFbn+mDxaQDgA1Q07KUqan 4+wQ3OuOmJh6EDaps+zhDMRB2M/a+y7zViZQnxt/sdyAdVm1CJv+TNl5W62P0eQtXqTn F3eRgx+1GkTTBVSB+j69MoZ6l1gufeehNzy27GmhMNIO3iUou3JGSqEBwOspXWDeCdvt +r+A== X-Gm-Message-State: AOAM533MhgzGJQC3z0Geprjr+BlK9bYwLieQQJgZ1lcIi8VHDDNx2HG8 so4X9K4rLsY7/aSgbl/RY8dFcuWFVW85SYRspqI= X-Google-Smtp-Source: ABdhPJz+XwSZEsot9WSddIHt+Smjp2bQLw8QvwRq8Bbc8xy2jPjwL5LuD+MHb0dLZPVfW7XorV5QZMi8b9/ETRscW2U= X-Received: by 2002:a25:4744:: with SMTP id u65mr462730yba.239.1610508550965; Tue, 12 Jan 2021 19:29:10 -0800 (PST) MIME-Version: 1.0 References: <20210112183529.2011863-1-f4bug@amsat.org> In-Reply-To: <20210112183529.2011863-1-f4bug@amsat.org> From: Bin Meng Date: Wed, 13 Jan 2021 11:29:00 +0800 Message-ID: Subject: Re: [RFC PATCH v6 00/11] hw/ssi: imx_spi: Fix various bugs in the imx_spi model To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2e; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Bin Meng , Xuzhou Cheng , Alistair Francis , "qemu-devel@nongnu.org Developers" , Jean-Christophe Dubois , qemu-arm , Peter Chubb Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Philippe, On Wed, Jan 13, 2021 at 2:35 AM Philippe Mathieu-Daud=C3=A9 wrote: > > Hi, > > As it is sometimes harder for me to express myself in plain > English, I found it easier to write the patches I was thinking > about. I know this doesn't scale. > > So this is how I understand the ecSPI reset works, after > looking at the IMX6DQRM.pdf datasheet. > > This is a respin of Ben's v5 series [*]. > Tagged RFC because I have not tested it :) Unfortunately this series breaks SPI flash testing under both U-Boot and VxWorks 7. > Sometimes changing device reset to better match hardware gives > trouble when using '-kernel ...' because there is no bootloader > setting the device in the state Linux expects it. > Given most of the new changes in this RFC series are clean-ups, I suggest we apply the v5 series unless there is anything seriously wrong in v5, IOW, don't fix it unless it's broken. Thoughts? Regards, Bin