From: Peter Maydell <peter.maydell@linaro.org>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Xu Wei <xuwei5@hisilicon.com>, Linuxarm <linuxarm@huawei.com>,
Eric Auger <eric.auger@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
sebastien.boeuf@intel.com, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH-for-4.2 v10 09/11] docs/specs: Add ACPI GED documentation
Date: Wed, 11 Sep 2019 13:54:23 +0100 [thread overview]
Message-ID: <CAFEAcA-0RKq_+wjuJKPUPp0E3=788WSMyBHGUctx2wYaDaWuFQ@mail.gmail.com> (raw)
In-Reply-To: <20190904085629.13872-10-shameerali.kolothum.thodi@huawei.com>
On Wed, 4 Sep 2019 at 09:58, Shameer Kolothum
<shameerali.kolothum.thodi@huawei.com> wrote:
>
> Documents basic concepts of ACPI Generic Event device(GED)
> and interface between QEMU and the ACPI BIOS.
>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> ---
> docs/specs/acpi_hw_reduced_hotplug.txt | 60 ++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 docs/specs/acpi_hw_reduced_hotplug.txt
New documentation in docs/specs should be in .rst format
and listed in docs/specs/index.rst, please. That way
it gets built into the sphinx manual sets we're transitioning
to. The rst markup should hopefully not be too difficult to add.
Some minor typo/grammar fixes below:
> +GED allows HW reduced platforms to handle interrupts in ACPI ASL
> +statements. It follows a very similar approach like the _EVT method
"similar approach to the"
> +from GPIO events. All interrupts are listed in _CRS and the handler
> +is written in _EVT method. However, Qemu implementation uses a single
"the QEMU implementation"
>+ interrupt for the GED device, relying on IO memory region to communicate
"on an IO memory region"
> +the type of device affected by the interrupt. This way, we can support
> +up to 32 events with a unique interrupt.
> + [0x0-0x3] Event selector bit field(32 bit) set by Qemu.
Missing space before '('.
"QEMU" should be all-capitals.
thanks
-- PMM
next prev parent reply other threads:[~2019-09-11 12:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 8:56 [Qemu-devel] [PATCH-for-4.2 v10 00/11] ARM virt: ACPI memory hotplug support Shameer Kolothum
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 01/11] hw/acpi: Make ACPI IO address space configurable Shameer Kolothum
2019-09-04 11:27 ` Igor Mammedov
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 02/11] hw/acpi: Do not create memory hotplug method when handler is not defined Shameer Kolothum
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 03/11] hw/acpi: Add ACPI Generic Event Device Support Shameer Kolothum
2019-09-11 12:34 ` Igor Mammedov
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 04/11] hw/arm/virt: Add memory hotplug framework Shameer Kolothum
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot Shameer Kolothum
2019-09-11 12:48 ` Igor Mammedov
2019-09-11 13:07 ` Igor Mammedov
2019-09-16 10:30 ` Shameerali Kolothum Thodi
2019-09-17 15:25 ` Igor Mammedov
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 06/11] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT Shameer Kolothum
2019-09-11 13:14 ` Igor Mammedov
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 07/11] hw/arm: Factor out powerdown notifier from GPIO Shameer Kolothum
2019-09-11 13:08 ` Igor Mammedov
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 08/11] hw/arm: Use GED for system_powerdown event Shameer Kolothum
2019-09-11 13:20 ` Igor Mammedov
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 09/11] docs/specs: Add ACPI GED documentation Shameer Kolothum
2019-09-11 12:54 ` Peter Maydell [this message]
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board Shameer Kolothum
2019-09-11 12:57 ` Peter Maydell
2019-09-11 13:50 ` Igor Mammedov
2019-09-11 13:55 ` Michael S. Tsirkin
2019-09-11 14:33 ` Shameerali Kolothum Thodi
2019-09-17 15:11 ` Michael S. Tsirkin
2019-09-17 15:23 ` Peter Maydell
2019-09-04 8:56 ` [Qemu-devel] [PATCH-for-4.2 v10 11/11] tests: Add bios tests to arm/virt Shameer Kolothum
2019-09-11 13:46 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-0RKq_+wjuJKPUPp0E3=788WSMyBHGUctx2wYaDaWuFQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=linuxarm@huawei.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=sebastien.boeuf@intel.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shannon.zhaosl@gmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).