From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F82C7618F for ; Mon, 22 Jul 2019 17:13:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C65BC2190F for ; Mon, 22 Jul 2019 17:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fS53v/nJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C65BC2190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbsG-0007vG-1g for qemu-devel@archiver.kernel.org; Mon, 22 Jul 2019 13:13:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47693) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbs1-0007Ay-Jq for qemu-devel@nongnu.org; Mon, 22 Jul 2019 13:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpbs0-0003mN-CR for qemu-devel@nongnu.org; Mon, 22 Jul 2019 13:13:05 -0400 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:35889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpbry-0003jV-Eb for qemu-devel@nongnu.org; Mon, 22 Jul 2019 13:13:02 -0400 Received: by mail-ot1-x335.google.com with SMTP id r6so41007869oti.3 for ; Mon, 22 Jul 2019 10:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1nSzYMlze+Th3/XpU+P9FLAQjtl5izZfuqt8BgeKgWc=; b=fS53v/nJsxao5V+BEjdghJlXCWF5/CiiUHcIWob6u31d31e+so1glfjmzLjsCeAFA/ gDL+118E14ezAVltvuOYV5voP4+PlldHPz5r7xKpEy9eZKZinKoR71dBytOQq8CXYIEk umHKOwGi42ofYCubT3oPHK5xvmpEleZ0T0Nr+eYVr3hEb/HoYB/309QKxQqre7HLzkzS RoEROB6lJB50kdGgmCY81JZ8dtjZhGj8eB1gTzXCqBZC/L3RUUunzc8sxHdsvUxwxcxt GBoTf89223HE/z2mMh8Nb7bCk8bLYBzuyRGCzdNDK4fkLddYENS4LX8JFI2+raomTptJ 4MBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1nSzYMlze+Th3/XpU+P9FLAQjtl5izZfuqt8BgeKgWc=; b=cAD1NLky+jDELXdlYrnLiiEvUca0dfrSeZ5enFpOUofG8wIcFfXyqdh0x+tReomt9L yS6yhSYvebwlAJfDLP/rtHZrGwp8iSkWyZXZptJbfYvJDAt9UhHe1EGhJQKOLGkSG0L/ QGq13EF1qg1lsyBWXRR9KgCOryOOkfZU+LE5oHuu/vniVZxA0IfBcE+/MkD7Sq7pUBTW inWOovRCDeRLqEzQ4+lvvMLnuNFCI/DGzUsk58/Exz9mkX1B1Q0C58YL+iIeuZ36uIC3 4k+YqV64j5MbZgG5SANtBxT7SPM5UfQ3tZk2TIMyQ8NjPuRagyJwGj+U5T86M/wlVCAO Tbaw== X-Gm-Message-State: APjAAAVlFZSPQjfr71Oa6QMpd+enk4OUbde8wH3A0td+9yPPgRaLQ0+l xiG9W4/BJaQWlzU9FELQ0C6iyQQ/TMndMuN9jXd7BQ== X-Google-Smtp-Source: APXvYqz/8kD5JvSWsBAA5zPe9ZKG52BDtdaZXIOj45jT+dN2qcdIjSxQ5JAYxkAnZE71eZpxO8DBpNc/JAzZu/4Vwo8= X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr22393221otn.135.1563815578762; Mon, 22 Jul 2019 10:12:58 -0700 (PDT) MIME-Version: 1.0 References: <20190718104837.13905-1-philmd@redhat.com> <20190718104837.13905-2-philmd@redhat.com> <5e6b8a67-8f8a-3e3b-4f42-db2a31c03ad1@redhat.com> <053eeafe-4e93-aa96-f544-ea0606e244b6@redhat.com> <689b75f8-ae47-621f-44a5-f3ad07fe2661@redhat.com> <63ff0471-aa50-f60d-417b-c42d315e02e3@redhat.com> In-Reply-To: <63ff0471-aa50-f60d-417b-c42d315e02e3@redhat.com> From: Peter Maydell Date: Mon, 22 Jul 2019 18:12:48 +0100 Message-ID: To: Laszlo Ersek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 Subject: Re: [Qemu-devel] [PATCH-for-4.1 v7 1/1] hw/block/pflash_cfi01: Add missing DeviceReset() handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster , Qemu-block , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Max Reitz , Alistair Francis , John Snow , "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Jul 2019 at 17:51, Laszlo Ersek wrote: > > On 07/19/19 18:19, Philippe Mathieu-Daud=C3=A9 wrote: > > Hi Laszlo, > > > > On 7/18/19 9:35 PM, Philippe Mathieu-Daud=C3=A9 wrote: > >> On 7/18/19 8:38 PM, Laszlo Ersek wrote: > >>> Regression-tested-by: Laszlo Ersek > > > > Patchwork doesn't recognize your R-t-b tag: > > > > https://patchwork.ozlabs.org/patch/1133671/ > > > > Should I change it for a Tested-by, or add as it? > > Please pick it up manually, as it is, if that's possible. > > I prefer to dedicate "Tested-by" to cases where my before-after > comparison highlights a difference (i.e., bug disappears, or feature > appears). I dedicate "R-t-b" to cases where nothing observable changes > (in accordance with my expectation). The counter-argument to this is that nobody else is using this convention (there are exactly 0 instances of "Regression-tested-by" in the project git log as far as I can see), and so in practice people reading the commits won't really know what you meant by it. Everybody else on the project uses "Tested-by" to mean either of the two cases you describe above, without distinction... (At one point we talked about using checkpatch to enforce that we used a particular set of tags, mostly to avoid people managing to typo the tagname, but also partly to retain some consistency of usage.) thanks -- PMM