From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Alistair Francis <alistair23@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs
Date: Thu, 15 Feb 2018 13:17:50 +0000 [thread overview]
Message-ID: <CAFEAcA-AfiDp5Y1MiveFHCZgTKgLPb3Qzu=RdhzNaD0yE4XscA@mail.gmail.com> (raw)
In-Reply-To: <422117c4-4d0b-5db8-9c2a-4e85e2502694@amsat.org>
On 15 February 2018 at 13:04, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Peter,
>
> On 02/15/2018 08:29 AM, Peter Maydell wrote:
>> On 2 February 2018 at 00:42, Alistair Francis
>> <alistair.francis@xilinx.com> wrote:
>>> List all possible valid CPU options.
>>>
>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>>
>>> V5:
>>> - Use cpu_model names
>>> V4:
>>> - Remove spaces
>>> V3:
>>> - Add static property
>>> V2:
>>> - Fix the indentation
>>>
>>> hw/arm/raspi.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
>>> index cd5fa8c3dc..745a880726 100644
>>> --- a/hw/arm/raspi.c
>>> +++ b/hw/arm/raspi.c
>>> @@ -158,6 +158,11 @@ static void raspi2_init(MachineState *machine)
>>> setup_boot(machine, 2, machine->ram_size - vcram_size);
>>> }
>>>
>>> +static const char *raspi2_valid_cpus[] = {
>>> + "cortex-a7",
>>> + NULL
>>> +};
>>
>> Is this definitely right? Looking at the code, the raspi2 board
>> creates a TYPE_BCM2836, and that creates cortex-a15 CPUs...
>
> The BCM2836 use a cortex-a7 but this cpu was not available at the time
> of this commit (bad5623690b) and was added later in dcf578ed8ce "The A7
> is very similar to the A15."
>
> I can prepare a patch for it to apply before this series.
I noticed after I'd written that comment that patch 3 in this
series does exactly the change to cortex-a7...
thanks
-- PMM
next prev parent reply other threads:[~2018-02-15 13:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 0:42 [Qemu-devel] [PATCH v5 0/6] Add a valid_cpu_types property Alistair Francis
2018-02-02 0:42 ` [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model Alistair Francis
2018-02-02 18:23 ` Eduardo Habkost
2018-02-05 11:22 ` Igor Mammedov
2018-02-05 13:54 ` Eduardo Habkost
2018-02-05 14:42 ` Igor Mammedov
2018-02-05 22:42 ` Eduardo Habkost
2018-02-06 14:43 ` Igor Mammedov
2019-06-17 5:09 ` Philippe Mathieu-Daudé
2019-06-17 14:43 ` Eduardo Habkost
2019-06-17 15:01 ` Igor Mammedov
2019-06-17 15:15 ` Philippe Mathieu-Daudé
2019-06-17 15:33 ` Igor Mammedov
2019-06-17 16:27 ` Eduardo Habkost
2019-06-18 11:34 ` Igor Mammedov
2019-06-18 13:55 ` Eduardo Habkost
2019-06-20 9:02 ` Igor Mammedov
2019-06-20 14:43 ` Eduardo Habkost
2020-01-23 18:48 ` Philippe Mathieu-Daudé
2020-02-06 20:59 ` Eduardo Habkost
2018-02-02 0:42 ` [Qemu-devel] [PATCH v5 2/6] netduino2: Specify the valid CPUs Alistair Francis
2018-02-02 0:42 ` [Qemu-devel] [PATCH v5 3/6] bcm2836: Use the Cortex-A7 instead of Cortex-A15 Alistair Francis
2018-02-15 13:23 ` Philippe Mathieu-Daudé
2018-02-15 22:41 ` Alistair Francis
2018-02-02 0:42 ` [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs Alistair Francis
2018-02-15 11:29 ` Peter Maydell
2018-02-15 13:04 ` Philippe Mathieu-Daudé
2018-02-15 13:17 ` Peter Maydell [this message]
2018-02-15 17:08 ` Igor Mammedov
2018-02-02 0:42 ` [Qemu-devel] [PATCH v5 5/6] xlnx-zcu102: " Alistair Francis
2018-02-02 0:42 ` [Qemu-devel] [PATCH v5 6/6] xilinx_zynq: " Alistair Francis
2018-03-13 23:13 ` [Qemu-devel] [PATCH v5 0/6] Add a valid_cpu_types property Philippe Mathieu-Daudé
2018-03-21 14:33 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-AfiDp5Y1MiveFHCZgTKgLPb3Qzu=RdhzNaD0yE4XscA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).