From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6298C433E0 for ; Tue, 2 Feb 2021 15:02:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 287F064F54 for ; Tue, 2 Feb 2021 15:02:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 287F064F54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6xCD-0000zM-47 for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 10:02:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6ws9-0000zX-Ss for qemu-devel@nongnu.org; Tue, 02 Feb 2021 09:41:42 -0500 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:46688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6ws7-0000wk-92 for qemu-devel@nongnu.org; Tue, 02 Feb 2021 09:41:41 -0500 Received: by mail-ej1-x634.google.com with SMTP id rv9so30295670ejb.13 for ; Tue, 02 Feb 2021 06:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yHnxhOqk/eWecdIgWfGTIuHn7pYl3vv+BgylfG2927A=; b=RvlV1FfjwB4zjHW0LIO92VhNb75JQImSQ/cPsJEJHWa7k9+i90JUFVprhCpiO5yE0B YIluFDeWoHGoTYnvbG56Y1kJCijgHnKw3yYQ7O9C2DIjAYx75XVyP0aMzMF3FpNjzdOn L7WpgNncg6zX67raQzxmuzjLnA+5wE/6jiM5O37r8Ni4RU0P0ngy/ERPkJJcDKEoSHBx Q8DFA9KMY8Kn0YjX66aM4B7ybqByLvmMXuh+8jNcoWMGiY1GBH/UvrB9xDADBEvwOzEE SIHxA1XoHIcfyGtVNUCzyg5WsFEHqk5Xlb7gdxn85QVSBmLZHDtW4U1n7ZA94SMdxZM9 K8OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yHnxhOqk/eWecdIgWfGTIuHn7pYl3vv+BgylfG2927A=; b=ql1J/gU5Aa0nzl1Ndrr8VXSe6YRTgvi8F0/Hsuq9soDdTOjACFWeM4XTsj/Bk4YPAQ rF6n+PpPtLFdEgvxnFDhTnAeyneAXtczRPDHinmc8cYcptP6XmPeGSqUwE+ryD40bTY/ YP97suHpvwaD3vt/wSgtXBNVID14uDtBUvX2NQjjZJA8RcNu2pl8Hg7Jbv5k7kBnTnO9 HGUH+BYo0c2y63Vm7zvvsqvwbkHnmbci+EbPLfAWyCLhdHB8plRadGY57DhvyMHQIC2e 6xLALgvAnachVbK09hj0q1qErdICWpXxA+5UC2tAiap2RHifCcz0HuRouQpZfFEMIHY7 V0fA== X-Gm-Message-State: AOAM530ofc2ammBtsgsaBZbc7jT9XdBa5/SOQ1JrJOv3iJMr6k7rCzUi d1oZi03TQmCH+gjZePt+/unidPbjUmm+yrCoXgDG/UZsL6M= X-Google-Smtp-Source: ABdhPJypkuZDB2wsj6XW+aqXIv5CE8RCJVqEnUtsGijLA8+Byy3Lm/1PwgLu7psefeINwT5In279D0bwsZH9wBKVqqY= X-Received: by 2002:a17:906:3603:: with SMTP id q3mr21981811ejb.382.1612276897774; Tue, 02 Feb 2021 06:41:37 -0800 (PST) MIME-Version: 1.0 References: <20210128224141.638790-1-richard.henderson@linaro.org> <20210128224141.638790-15-richard.henderson@linaro.org> In-Reply-To: <20210128224141.638790-15-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 2 Feb 2021 14:41:26 +0000 Message-ID: Subject: Re: [PATCH v4 14/23] target/arm: Use the proper TBI settings for linux-user To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 28 Jan 2021 at 22:42, Richard Henderson wrote: > > We were fudging TBI1 enabled to speed up the generated code. > Now that we've improved the code generation, remove this. > Also, tidy the comment to reflect the current code. > > The pauth test was testing a kernel address (-1) and making > incorrect assumptions about TBI1; stick to userland addresses. > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 4 ++-- > target/arm/cpu.c | 10 +++------- > tests/tcg/aarch64/pauth-2.c | 1 - > 3 files changed, 5 insertions(+), 10 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM