From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EC5C4338F for ; Fri, 20 Aug 2021 17:15:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A842161163 for ; Fri, 20 Aug 2021 17:15:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A842161163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH86s-0006zB-LD for qemu-devel@archiver.kernel.org; Fri, 20 Aug 2021 13:15:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH85y-0006Ez-1n for qemu-devel@nongnu.org; Fri, 20 Aug 2021 13:14:18 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:44795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mH85w-0000pi-Iq for qemu-devel@nongnu.org; Fri, 20 Aug 2021 13:14:17 -0400 Received: by mail-ed1-x532.google.com with SMTP id s3so2715983edd.11 for ; Fri, 20 Aug 2021 10:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nb1dIzmHK1yhbwxQgwsLAJaBpW0gFe8PthvVsdukGWk=; b=KsWhewmW87q69dnEYcV0jvFa8tHOdiH4BmzHTDMF0w13wTiakmsA8cmoxlKD9xq8UD 5IWvsbl7PycjqrDUDkwXcxgFUM9UK8vcfPSsd7SQA0ZfWbMktngajvwidQsjxXaIpBMc M3dhxpEryaqgNWHoLsWX8yy0/cDSgwOj6tAnjWkkjMYFDOAX9uIphqEowecfjFmq/MPj z6uerdvM7OiOC7utIiI4jgLK0Lcn/LXerfbJVO6j30IGlxuUH9HK5ofacRMou4oXM5xS yivg/UYPSAWIV+XFZNajhhhjw9byotES7AloyHhmZegOHgH5iPeZUnJ9UHOh6kYcUU9q OPFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nb1dIzmHK1yhbwxQgwsLAJaBpW0gFe8PthvVsdukGWk=; b=Ikknj8GpgmcMkUbOmRa84W88vCcJadFbCsKlyl/EK16VbzVqXZo7MJUBuA18mLypp0 lCNyp6uyAhs4/JrlVuyTKZ70wXk9UCoyugnIeZ9tragDOSROMifESQzbhDocce5M93JN vsCxz8Id1q5zHpw/HfKpa62+d4ylDco1q5rqL2iSB+5iscKj8P8onYz6rTGAoSJQzbSB FzjnHWQjfgCtHWgyVI/jruP+xOLOshlpSIV5NAGTCVE07ADtJnoOoef7v+LUyF7w3QQL 4k/ADERyqzrudafR6/p9IL2fwPChO/5VIBWC5RnvgIuoioXhbTVkgOxDnj1FAkb6G3e5 Er0Q== X-Gm-Message-State: AOAM533WwV0r3mYZG5Zni+q65Im543EBkeqya7GisNS++AmImCm/xhb+ SEd6lR21OsUGU42sPopFjwXax0w1LB52BeZPVRn+EA== X-Google-Smtp-Source: ABdhPJwL7zoOdGJhc9vNDtBek1fDdkJQFEAZSNhV5Wk20TyA1PM7QzVAJWDegdippC+2h2QYf32VgnJBrAY4vEqqnh4= X-Received: by 2002:aa7:c0c6:: with SMTP id j6mr12251009edp.146.1629479655098; Fri, 20 Aug 2021 10:14:15 -0700 (PDT) MIME-Version: 1.0 References: <20210820155211.3153137-1-philmd@redhat.com> <20a53e29-ba23-fe0d-f961-63d0b5ca9a89@redhat.com> <20210820184048.4a5294c4@redhat.com> <5699e784-f120-25e8-d0c6-b3e53ed0b883@redhat.com> In-Reply-To: <5699e784-f120-25e8-d0c6-b3e53ed0b883@redhat.com> From: Peter Maydell Date: Fri, 20 Aug 2021 18:13:28 +0100 Message-ID: Subject: Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Markus Armbruster , QEMU Developers , Peter Xu , "Dr. David Alan Gilbert" , Paolo Bonzini , Igor Mammedov , Bin Meng Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 20 Aug 2021 at 17:59, Philippe Mathieu-Daud=C3=A9 wrote: > Anyhow I still see the size displayed in the error message as an > useful hint: > > $ qemu-system-i386 -m 64000 > qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate > memory > > VS: > > $ qemu-system-i386 -m 64000 > qemu-system-i386: Cannot set up 62.5 GiB of guest memory 'pc.ram': > Cannot allocate memory I hadn't spotted that we were doing the size-to-str -- I think that's definitely helpful because it will catch cases like the one here where the user didn't realize they were asking for 30 terabytes of RAM... -- PMM