From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 286D2C433EF for ; Tue, 21 Sep 2021 15:33:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B39916115A for ; Tue, 21 Sep 2021 15:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B39916115A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mShm2-00082l-QP for qemu-devel@archiver.kernel.org; Tue, 21 Sep 2021 11:33:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mShjj-0006DG-V2 for qemu-devel@nongnu.org; Tue, 21 Sep 2021 11:31:15 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:45820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mShje-0000DG-T1 for qemu-devel@nongnu.org; Tue, 21 Sep 2021 11:31:09 -0400 Received: by mail-wr1-x42c.google.com with SMTP id d21so40361273wra.12 for ; Tue, 21 Sep 2021 08:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Emk/Bda1m5kTVjM/t5vCSYRFTM3gUMVDT42meUXin48=; b=Ogf0snClip/6IIjVc9QIs36FRrWuP8twyokm6VP0uUgvnZGvnSQ7OFv4m/2PMt655s /dJRbQZJrfVmTWLzE6z0UcmnWAgZ+k6iQ6tWOpVYAdVCjguNd9C6QtmmfVFJaDmVrqQh hLKrV5zQFtk9rH23WOep/1xWJZMXveR3enLgqu/kKBVJQ5OoRbcwQ2VyLR6gB9miZKj/ 3liPntnf8mX1urFodMaVEJCfR52/Z5+RP5AXOD0AreDGO0i2ljKncX+NRIm7eAPSwZm+ Ouwj8ZDNnQkuVKp2Tn2BOYnttXtvgPM+2B/qIobG+wx1g9n2Vkl01S5er9iJ8gGBnJSX +sSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Emk/Bda1m5kTVjM/t5vCSYRFTM3gUMVDT42meUXin48=; b=EymhhHFNLJPdo0pTl/7zOg4P6Zk0UxD4ZqaFSGGUSLh3/ArKnQ09XucsxYrKJgASjV zZXwN+7/EKBI1fFiLtM6nZQciDqhdsrhwTKpZzMtj2kl1qqMN5rRDApIF61LrLR0VKIq /tPwUxzk1qmGRPmAWNp1kLS2tZKNnPB2F3PluBiGYrhRltBh0F7ECqr/BWROhSZgaxfx UuqMQWR9POuES/01FNVOr8IGPzKPdmQNRr+uPDvXA/V2XwiOLPKtgzeRJlW+XSKxmLWX UcFRmayKF9AYDukT3Bi3SdysC2HyVzkVplhOMBpxJR7Ey8H+n7mRQm2eXkf7kBowgq8A VU1A== X-Gm-Message-State: AOAM531qFyLTReyaoQXOP+TcrFJnHn1zhQzQMy1iimLjpMH8y0UAgHZt QPZf1XGCpIJYdEgHc4tMjkQOxqNSrU3ay6iUzXoITQ== X-Google-Smtp-Source: ABdhPJzK7uK3t7Xercw47T6I1V/OoU9S/ESUNwI8tAjWLomHzw9dFor5+nBk5XQJMklwk4xD2ssDIIFm/dJPNnUkEYw= X-Received: by 2002:adf:fd12:: with SMTP id e18mr36020486wrr.275.1632238263634; Tue, 21 Sep 2021 08:31:03 -0700 (PDT) MIME-Version: 1.0 References: <20210916155404.86958-1-agraf@csgraf.de> <20210916155404.86958-5-agraf@csgraf.de> In-Reply-To: <20210916155404.86958-5-agraf@csgraf.de> From: Peter Maydell Date: Tue, 21 Sep 2021 16:30:11 +0100 Message-ID: Subject: Re: [PATCH v12 04/10] hvf: Add Apple Silicon support To: Alexander Graf Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , Peter Collingbourne , Richard Henderson , QEMU Developers , Cameron Esfahani , Roman Bolshakov , qemu-arm , Frank Yang , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 16 Sept 2021 at 16:54, Alexander Graf wrote: > > With Apple Silicon available to the masses, it's a good time to add support > for driving its virtualization extensions from QEMU. > > This patch adds all necessary architecture specific code to get basic VMs > working, including save/restore. > > Known limitations: > > - WFI handling is missing (follows in later patch) > - No watchpoint/breakpoint support > > Signed-off-by: Alexander Graf > Reviewed-by: Roman Bolshakov > Reviewed-by: Sergio Lopez > Reviewed-by: Peter Maydell This broke compilation on x86 osx: > --- a/target/i386/hvf/hvf.c > +++ b/target/i386/hvf/hvf.c > @@ -206,6 +206,11 @@ static inline bool apic_bus_freq_is_known(CPUX86State *env) > return env->apic_bus_freq != 0; > } > > +void hvf_kick_vcpu_thread(CPUState *cpu) > +{ > + cpus_kick_thread(cpu); > +} This won't build without an extra #include "sysemu/cpus.h". I've folded in the fix. -- PMM