From: Peter Maydell <peter.maydell@linaro.org>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cornelia Huck" <cohuck@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Greg Kurz" <groug@kaod.org>, qemu-s390x <qemu-s390x@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, qemu-ppc <qemu-ppc@nongnu.org>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM
Date: Thu, 30 Jul 2020 16:47:30 +0100 [thread overview]
Message-ID: <CAFEAcA-VFaZiR58F-zDo6h_Q-U5gU1O3RDnOcuCnwnuqD_JFSg@mail.gmail.com> (raw)
In-Reply-To: <20200723025657.644724-1-bauerman@linux.ibm.com>
On Thu, 23 Jul 2020 at 03:57, Thiago Jung Bauermann
<bauerman@linux.ibm.com> wrote:
>
> The ARM code has a start-powered-off property in ARMCPU, which is a
> subclass of CPUState. This property causes arm_cpu_reset() to set
> CPUState::halted to 1, signalling that the CPU should start in a halted
> state. Other architectures also have code which aim to achieve the same
> effect, but without using a property.
>
> The ppc/spapr version has a bug where QEMU does a KVM_RUN on the vcpu
> before cs->halted is set to 1, causing the vcpu to run while it's still in
> an unitialized state (more details in patch 3).
>
> Peter Maydell mentioned the ARM start-powered-off property and
> Eduardo Habkost suggested making it generic, so this patch series does
> that, for all cases which I was able to find via grep in the code.
Acked-by: Peter Maydell <peter.maydell@linaro.org>
for the Arm bits if you want to take the bug-fixing parts of
this series in via some other tree. (I think they've all been
reviewed.)
thanks
-- PMM
next prev parent reply other threads:[~2020-07-30 16:06 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 2:56 [PATCH v3 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-07-23 2:56 ` [PATCH v3 1/8] target/arm: Move start-powered-off property to generic CPUState Thiago Jung Bauermann
2020-07-23 3:06 ` David Gibson
2020-07-23 3:33 ` Thiago Jung Bauermann
2020-07-27 12:36 ` Greg Kurz
2020-07-28 23:00 ` Thiago Jung Bauermann
2020-07-23 2:56 ` [PATCH v3 2/8] target/arm: Move setting of CPU halted state to generic code Thiago Jung Bauermann
2020-07-23 3:06 ` David Gibson
2020-07-27 12:39 ` Greg Kurz
2020-07-23 2:56 ` [PATCH v3 3/8] ppc/spapr: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-07-23 3:06 ` David Gibson
2020-07-27 13:28 ` Greg Kurz
2020-07-28 23:03 ` Thiago Jung Bauermann
2020-07-27 14:25 ` Philippe Mathieu-Daudé
2020-07-23 2:56 ` [PATCH v3 4/8] ppc/e500: " Thiago Jung Bauermann
2020-07-23 3:07 ` David Gibson
2020-07-23 2:56 ` [PATCH v3 5/8] mips/cps: " Thiago Jung Bauermann
2020-07-23 3:07 ` David Gibson
2020-07-23 2:56 ` [PATCH v3 6/8] sparc/sun4m: Remove main_cpu_reset() Thiago Jung Bauermann
2020-07-23 3:08 ` David Gibson
2020-07-23 2:56 ` [PATCH v3 7/8] sparc/sun4m: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-07-23 3:08 ` David Gibson
2020-07-27 14:15 ` Philippe Mathieu-Daudé
2020-07-23 2:56 ` [RFC PATCH v3 8/8] target/s390x: " Thiago Jung Bauermann
2020-07-27 12:43 ` Cornelia Huck
2020-07-29 0:51 ` Thiago Jung Bauermann
2020-07-30 9:45 ` Cornelia Huck
2020-08-11 11:04 ` Cornelia Huck
2020-08-13 1:25 ` Thiago Jung Bauermann
2020-07-29 0:56 ` [PATCH v3 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-07-30 0:59 ` David Gibson
2020-07-30 11:05 ` Philippe Mathieu-Daudé
2020-07-30 15:04 ` Thiago Jung Bauermann
2020-08-05 17:01 ` Thiago Jung Bauermann
2020-08-05 19:04 ` Peter Maydell
2020-08-05 20:22 ` Thiago Jung Bauermann
2020-08-06 5:13 ` David Gibson
2020-08-06 9:17 ` Peter Maydell
2020-07-30 15:47 ` Peter Maydell [this message]
2020-08-17 4:47 ` David Gibson
2020-08-17 5:24 ` Philippe Mathieu-Daudé
2020-08-17 5:43 ` David Gibson
2020-08-18 1:43 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-VFaZiR58F-zDo6h_Q-U5gU1O3RDnOcuCnwnuqD_JFSg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bauerman@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).