From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B422CC433E6 for ; Mon, 22 Feb 2021 14:21:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D96864E41 for ; Mon, 22 Feb 2021 14:21:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D96864E41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEC5t-0008BP-4j for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 09:21:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEC4C-00076G-9s for qemu-devel@nongnu.org; Mon, 22 Feb 2021 09:20:04 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:46574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEC47-0002kP-Pd for qemu-devel@nongnu.org; Mon, 22 Feb 2021 09:20:03 -0500 Received: by mail-ej1-x636.google.com with SMTP id r17so3269000ejy.13 for ; Mon, 22 Feb 2021 06:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3cwrLLT0Sx9k75ti66df7DS3UlSsbDApUDJDHCs2JTY=; b=V5VwBSKZE6lmk+tMck7o6JaCovm4/VrH0ZOChaO/PbwiOFp564GqEkxqbmntq08l5J olXmIoy9RrPPC+qWKGOxQBFMcw/MwNmwf0gNEtKBzEVMEcqnFeVni4EIysaj6skQrxPy HwGN3tZBU5NNIx6AcQim+1FoqWCZ2qfHIPFVOjVM3fawYQDm+vMQmmTW7sVEhP0ALUw1 +S1opHAqFfRjosuxp5YMaYi9TQkCm7cx45G4N3zYMk8TqzYat/qXOvKyG2Pt+GzuxkAd 5at8ox99mAyKmSBKUiBQ7bCPsoFxKmzBZoI2tUNu5bdMEiD9rIFxdpwYXeIeB7LTmCVt MD4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3cwrLLT0Sx9k75ti66df7DS3UlSsbDApUDJDHCs2JTY=; b=a/CseY+kU+p0bNwms73Pmvx5nnINyik8iURB0jnroILxhSuJkB7LBH1/YXCcb2pl3o RTKB1yAudWrTMy+el2mwBOyoN0ja8TMlM9JXxWf6gs0bxrD/XHFXiEttPM2rqcyjuJvH 99ki9vputNY5Z7tz22bNRUM+kjF5zuEgiUT7vEDl0XNGh7auknu+hqLCfy43LPSeXmW+ PR5lIDyVlxZYbjlRfdhL9ZJsAFmHofECYT16QhCKE3i6i7ssYyGF5xsF/v4xEeOR7N+F 7/QA8JmvHzygZ9ZxbQjikRBcODaoGx/WmH/GJIQ+Xb2CaCoNPJvKbiMZltpkQ88mzt4f B3+w== X-Gm-Message-State: AOAM5307+cVlxRfAObsEFQjg4D134IsbWir/G/1nG92l7Pf8xHA5VGYQ bkQBEKJipcHZU/pOnqNFeC5ENAs5K+Omg1JdUpp1Dw== X-Google-Smtp-Source: ABdhPJwGRfqzWnroS02Kl1/5JwUTc8Ui8Iemqh3OH0V0zMxdk6wgoaSE5X9441+U1GsU1Xx/YoeFKzfvdGvkIzlK2bw= X-Received: by 2002:a17:906:ca58:: with SMTP id jx24mr18259995ejb.482.1614003569694; Mon, 22 Feb 2021 06:19:29 -0800 (PST) MIME-Version: 1.0 References: <20210221215915.2568943-1-f4bug@amsat.org> <20210221215915.2568943-2-f4bug@amsat.org> In-Reply-To: From: Peter Maydell Date: Mon, 22 Feb 2021 14:19:18 +0000 Message-ID: Subject: Re: [PATCH v3 1/8] hw/sh4: Add missing license To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Qemu-block , Yoshinori Sato , Magnus Damm , QEMU Developers , Max Reitz , Samuel Tardieu , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , =?UTF-8?B?QWxleCBCZW5uw6ll?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Feb 2021 at 14:13, Philippe Mathieu-Daud=C3=A9 = wrote: > > On 2/22/21 2:55 PM, Peter Maydell wrote: > > On Sun, 21 Feb 2021 at 21:59, Philippe Mathieu-Daud=C3=A9 wrote: > >> > >> This code was introduced in commit 27c7ca7e775, > >> ("SHIX board emulation (Samuel Tardieu)"). Use > >> the same license. > > I thought it wasn't generally recommended to convert > > a license text to a single SPDX line? The sh7750.c file > > has a full 3-para license text. > > Yes you are right, sorry. I'll respin. Also on the subject of sh4 code licenses, hw/sh4/sh7750_regs.h has * The license and distribution terms for this file may be * found in the file LICENSE in this distribution or at * http://www.rtems.com/license/LICENSE. because it's borrowed from RTEMS. (The license at the URL is gpl-2-or-later with a header exception). Maybe we should expand the license in-place so we're not dependent on a 3rd party website to stay up to tell us what the license on the file is? In particular I assume the comment really means "the file LICENSE in the rtems distribution" https://git.rtems.org/rtems/tree/LICENSE (same text as web page) and not the file LICENSE in QEMU, which is not the same thing, so that part is actively misleading. -- PMM