From: Peter Maydell <peter.maydell@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc <qemu-ppc@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>,
Paul Clarke <pc@us.ibm.com>,
Aleksandar Markovic <aleksandar.m.mail@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Three floating point fixes
Date: Tue, 20 Aug 2019 11:35:29 +0100 [thread overview]
Message-ID: <CAFEAcA-qCRH-a7oGj3K_gvBVTq_JR8LjsorZuOKOP+w4pk4G6A@mail.gmail.com> (raw)
In-Reply-To: <20190820073114.GC20890@umbus>
On Tue, 20 Aug 2019 at 08:36, David Gibson <david@gibson.dropbear.id.au> wrote:
> On Mon, Aug 19, 2019 at 12:13:34PM -0500, Paul Clarke wrote:
> > These issues were found while running Glibc's test suite for "math",
> > and there are still a *LOT* of QEMU-only FAILs, so I may be back
> > again with suggested fixes or questions. :-)
>
> That doesn't greatly surprise me, TCG's ppc target stuff is only so-so
> tested, TBH.
You might also consider using/extending the risu test cases for
ppc64 -- individual checks of each insn against a known-good
implementation can be easier to track down bugs than trying
to figure out why a higher-level test suite like the glibc one
has reported a failure, IME. (There are already risu patterns
for XSCVDPSP and XSCVDPSPN, so I think that bug at least ought
to be found by risu if you run it against the right h/w as
known-good reference...)
thanks
-- PMM
next prev parent reply other threads:[~2019-08-20 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 19:27 [Qemu-devel] [PATCH] ppc: Three floating point fixes Paul A. Clarke
2019-08-16 22:59 ` Aleksandar Markovic
2019-08-17 7:53 ` Aleksandar Markovic
2019-08-18 8:10 ` Richard Henderson
2019-08-18 20:59 ` Aleksandar Markovic
2019-08-19 6:28 ` David Gibson
2019-08-19 6:44 ` Aleksandar Markovic
2019-08-19 17:13 ` [Qemu-devel] [Qemu-ppc] " Paul Clarke
2019-08-20 7:31 ` David Gibson
2019-08-20 10:35 ` Peter Maydell [this message]
2019-08-22 3:02 ` David Gibson
2019-08-18 8:00 ` [Qemu-devel] " Richard Henderson
2019-08-19 6:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-qCRH-a7oGj3K_gvBVTq_JR8LjsorZuOKOP+w4pk4G6A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aleksandar.m.mail@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=pc@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).