From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVhVU-000865-KG for qemu-devel@nongnu.org; Tue, 16 Feb 2016 10:25:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVhVQ-00068L-LF for qemu-devel@nongnu.org; Tue, 16 Feb 2016 10:25:40 -0500 Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:36053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVhVQ-000683-HH for qemu-devel@nongnu.org; Tue, 16 Feb 2016 10:25:36 -0500 Received: by mail-vk0-x234.google.com with SMTP id c3so135897958vkb.3 for ; Tue, 16 Feb 2016 07:25:36 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Peter Maydell Date: Tue, 16 Feb 2016 15:25:16 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 8/9] i.MX: Add sabrelite i.MX6 emulation. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jean-Christophe Dubois Cc: QEMU Developers , Peter Crosthwaite On 8 February 2016 at 22:08, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * output a message and exit if RAM size is unsupported. > > hw/arm/Makefile.objs | 2 +- > hw/arm/sabrelite.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 94 insertions(+), 1 deletion(-) > create mode 100644 hw/arm/sabrelite.c > > diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs > index ac383df..fc1df45 100644 > --- a/hw/arm/Makefile.objs > +++ b/hw/arm/Makefile.objs > @@ -15,4 +15,4 @@ obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o > obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp.o xlnx-ep108.o > obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o > obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o > -obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o > +obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o > diff --git a/hw/arm/sabrelite.c b/hw/arm/sabrelite.c > new file mode 100644 > index 0000000..8db9bbc > --- /dev/null > +++ b/hw/arm/sabrelite.c > @@ -0,0 +1,93 @@ > +/* > + * SABRELITE Board System emulation. > + * > + * Copyright (c) 2015 Jean-Christophe Dubois > + * > + * This code is licensed under the GPL, version 2 or later. > + * See the file `COPYING' in the top level directory. > + * > + * It (partially) emulates a sabrelite board, with a Freescale > + * i.MX6 SoC > + */ > + > +#include "hw/arm/fsl-imx6.h" You need to include "qemu/osdep.h" as the first #include in any source file. (I forgot to mention this for the earlier patches; please make sure you fix any other new source files in this patchset). [This is a new convention we're trying to bring in, so at the moment things will still compile without it, but if you can add the include that will save me coming along later with a fixup patch. And at some point qemu-common.h won't include osdep.h and files will no longer compile without it explicitly included first...] Otherwise Reviewed-by: Peter Maydell thanks -- PMM