From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F809C3A59F for ; Mon, 26 Aug 2019 19:43:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE1FB22CF5 for ; Mon, 26 Aug 2019 19:43:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lc/zL4s8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE1FB22CF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2KtJ-00042a-US for qemu-devel@archiver.kernel.org; Mon, 26 Aug 2019 15:43:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43573) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2KrG-00027R-I7 for qemu-devel@nongnu.org; Mon, 26 Aug 2019 15:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2KrF-0002K5-BD for qemu-devel@nongnu.org; Mon, 26 Aug 2019 15:40:54 -0400 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:37439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2KrF-0002JN-5T for qemu-devel@nongnu.org; Mon, 26 Aug 2019 15:40:53 -0400 Received: by mail-oi1-x244.google.com with SMTP id b25so13085445oib.4 for ; Mon, 26 Aug 2019 12:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NZSSeZtnXvtNng9emjct5L5Tp8giMMagrPLdTUJ8td4=; b=lc/zL4s845VczecveRn+y5Zj3SaGBFVx8qr0J3+kTdCgBeS/1mJ6PqGCwzN/qJo6c8 lQTdBR6ZhPSUehOHPiS8WfV14PckBg6UzrgqE5YEfUIBu+MdohTK3BrQeE4mlmVHjB+y jjkqxRRMiBJarm6GNuaBGAn1SIIsr06gUkUStCmM0LooPk/Pirp/ayCrtjLQke8DplO0 b+u1tcQ7f9u9t/FcwfebN2Fi0ERqWDTsTp8rz/Oc9rdWfgXW0/qTuFJXJipKlyoeRHmW fj00arrUCCVfhT/6ceCLjYOby60j2kWcqL8QjctZFytyagAOvvzW2ZsZJvJZadUao458 rPpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NZSSeZtnXvtNng9emjct5L5Tp8giMMagrPLdTUJ8td4=; b=GLwuIVRWPyMdrLMtDygY94ZS+R7Q+MHVeidnfavMWVg0TC2TQLcoahxflroqlCBLwP 9jpugCMh9UaOfe8/iKprg1i0CyoUuu4GSb6JFw6IEq2DcwuVbk/8qAP6otN5ryGiX3jp ElwtkToe3TitaU0az3SnhTTTLQvkCFZm9bfMbSCo+qb4IB3nk6/hNTuBDpJ3l7hFFRTH lXnhxL8UoTeU86WzVMUgiYamlmWnVavqHs78MuubqF3SxbMSh8v0nOJF8f2mi77yYelY fuZu9HyeTfn4LTL5+PN1wQCyj5aTWDL0XsJ2TjF9v/6XiDf6Z636k+noHojnO/CzlGO4 kQXQ== X-Gm-Message-State: APjAAAU43cVkl5lfiX0/plP1ydPnhjrAben7PCwsVUC/ktkRBJtR1k6X +9naVEPwhbdPAnPc4sQ0lXqr50kVDbQtLKNk5I2ypw== X-Google-Smtp-Source: APXvYqyRpxQ3FbKE4fzCJwGguUxAD8OtR5hclV58FJ1U1YPWygUC0dOzt9J2Bka4oWPxppiNV121eRZi0dJNCFe0Tu0= X-Received: by 2002:aca:4a57:: with SMTP id x84mr13846359oia.170.1566848452125; Mon, 26 Aug 2019 12:40:52 -0700 (PDT) MIME-Version: 1.0 References: <20190819213755.26175-1-richard.henderson@linaro.org> <20190819213755.26175-60-richard.henderson@linaro.org> In-Reply-To: <20190819213755.26175-60-richard.henderson@linaro.org> From: Peter Maydell Date: Mon, 26 Aug 2019 20:40:41 +0100 Message-ID: To: Richard Henderson Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 Subject: Re: [Qemu-devel] [PATCH v2 59/68] target/arm: Split gen_nop_hint X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Now that there all callers pass a constant value, split the switch > statement into the individual trans_* functions. s/there//. Otherwise Reviewed-by: Peter Maydell thanks -- PMM