From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B917FC7618F for ; Mon, 15 Jul 2019 10:20:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 861C8206B8 for ; Mon, 15 Jul 2019 10:20:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NJaxPXR7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 861C8206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmy5S-0006jP-MF for qemu-devel@archiver.kernel.org; Mon, 15 Jul 2019 06:20:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34094) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmy5D-0006FR-66 for qemu-devel@nongnu.org; Mon, 15 Jul 2019 06:19:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmy5C-0004wb-7b for qemu-devel@nongnu.org; Mon, 15 Jul 2019 06:19:47 -0400 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:38561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmy5C-0004wA-2A for qemu-devel@nongnu.org; Mon, 15 Jul 2019 06:19:46 -0400 Received: by mail-ot1-x344.google.com with SMTP id d17so16395329oth.5 for ; Mon, 15 Jul 2019 03:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lIY1LG0oQiWA/CK7da0hwk56l330aVFg5UDC40kBwXQ=; b=NJaxPXR7Jxrl287frgOPqUvn3TPAGVR8D51mxlNs4wgqa9WpgxvFK8ZBEC6fIl+NC6 I2fp5C0ZBV2mjBtqlf8ZbeLgHO9v8InYaR/XrVnMCDaCDkn6wTO7TftqhWeH5eaKBlwW 0pl68SOIoc5Q5sttFlzXlwrOHDUbYFcw8j85xotZ+eG4iP8gtWxP5nSX4qIXdSiOxtjN zwrqlsLcBV3Jkh3uTBLPstjqKp3tXJ2j4Xm+D2YfB6GjE1bEgF+wqXLAV4rHrkZL4znH ffufe8v+PsSRimk6XO9RWMDDATh8LAlMspwMZVUF7WFu1KCPmn9H6Lbo8aWjmadLpvD4 UewA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lIY1LG0oQiWA/CK7da0hwk56l330aVFg5UDC40kBwXQ=; b=LXDIqYBoVEDNBDHTgE4zR7hBt0+NziMNiOrMxSGntjbvqljGpIiqnC+NF1HJpAh3dv hjqZb1ejDB3Ft+6Ikqb+LZeX9vxRzsNmjUdnD7XHFoofFaVwz3vvuKjo2hnlwGoUFUiJ LmHQW04GDvaOSNEyqSYtkzIb2ZoMWbY4EkgXhB8CNsQmXDPvycy5KXhfl2Xyjo9LmmCW i6NxvfNBwP6xOU4cjNkefWrGZP5ubM24DUBVvbo3I8wFcJ4h3kVX9H3h5BxzrIj6PhyI gHhnrzfFff23ojgLioGQPm44V6sb0WYqDrjmgepbxjrc3iA6/DlM/M5ftEwtdjCdKa6P Gc7A== X-Gm-Message-State: APjAAAU6ZwoJvvmvyT8uITVwHIeeAQjI2Mehuh+Qh9LgCZxXaasChEZH pdH/EQAFkXP09VP9Pg5PsNugklSwzfxjJkciyTE6Fw== X-Google-Smtp-Source: APXvYqwY5x2NdkXEmb5pW4QRgblB22LwfzhIEghQtU0ZM7P+StztfmQHnnRzLE05wNJOPoy/IMlOSOz8hjPWBYoXMoc= X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr14428381otn.135.1563185985085; Mon, 15 Jul 2019 03:19:45 -0700 (PDT) MIME-Version: 1.0 References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> In-Reply-To: From: Peter Maydell Date: Mon, 15 Jul 2019 11:19:34 +0100 Message-ID: To: Thomas Huth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::344 Subject: Re: [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc , "open list:RISC-V" , Eduardo Habkost , Sagar Karandikar , "Michael S. Tsirkin" , Helge Deller , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Artyom Tarasenko , "open list:S390" , qemu-arm , Alistair Francis , Gerd Hoffmann , Paolo Bonzini , David Gibson , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: > > On 15/07/2019 11.55, Philippe Mathieu-Daud=C3=A9 wrote: > > If a controller device provides a PCI bus, we can plug any PCI > > daughter card on it. > > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > --- > > diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig > > index 77f8b005ff..0f7267db35 100644 > > --- a/hw/pci/Kconfig > > +++ b/hw/pci/Kconfig > > @@ -1,5 +1,6 @@ > > config PCI > > bool > > + imply PCI_DEVICES > > No, please don't change this. This was done on purpose, since almost all > PCI_DEVICES do not work on s390x (so s390x does *not* imply PCI_DEVICES). But that means that every board that provides PCI has to have an "imply PCI_DEVICES" line, which is pretty clunky just to work around an s390x limitation. Is there some way in the Kconfig syntax for s390x to say "no PCI_DEVICES" so we can have the corner-case be handled by the s390x Kconfig in one place rather than in 20 places affecting everywhere except s390x? thanks -- PMM