From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH for-6.1 2/2] accel/tcg: Remove unnecessary check on icount_extra in cpu_loop_exec_tb()
Date: Sun, 25 Jul 2021 18:45:02 +0100 [thread overview]
Message-ID: <CAFEAcA-yUhjXwK5yPm1-uPTO+KmC5Lyv5UQbA5S3qFhzQNo4nQ@mail.gmail.com> (raw)
In-Reply-To: <20210725174405.24568-3-peter.maydell@linaro.org>
On Sun, 25 Jul 2021 at 18:44, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> In cpu_loop_exec_tb(), we decide whether to look for a TB with
> exactly insns_left instructions in it using the condition
> (!cpu->icount_extra && insns_left > 0 && insns_left < tb->icount)
>
> The check for icount_extra == 0 is unnecessary, because we just set
> insns_left = MIN(0xffff, cpu->icount_budget);
> icount_extra = icount_budget - insns_left;
> and so icount_extra can only be non-zero if icount_budget > 0xffff
> and insns_left == 0xffff. But in that case insns_left >= tb->icount
> because 0xffff is much larger than TCG_MAX_INSNS, so the condition
> will be false anyway.
>
> Remove the unnecessary check, and instead assert:
> * that we are only going to execute a partial TB here if the
> icount budget has run out (ie icount_extra == 0)
> * that the number of insns we're going to execute does fit into
> the CF_COUNT_MASK
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> You could argue that we don't need the asserts, if you like.
> The first one would have caught the bug fixed in the previous
> commit, though.
"first" in the bulleted list, "second" in the order I put them in the code...
> ---
> accel/tcg/cpu-exec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 6e8dc291197..5aa42fbff35 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -843,7 +843,9 @@ static inline void cpu_loop_exec_tb(CPUState *cpu, TranslationBlock *tb,
> * execute we need to ensure we find/generate a TB with exactly
> * insns_left instructions in it.
> */
> - if (!cpu->icount_extra && insns_left > 0 && insns_left < tb->icount) {
> + if (insns_left > 0 && insns_left < tb->icount) {
> + assert(insns_left <= CF_COUNT_MASK);
> + assert(cpu->icount_extra == 0);
> cpu->cflags_next_tb = (tb->cflags & ~CF_COUNT_MASK) | insns_left;
> }
> #endif
-- PMM
next prev parent reply other threads:[~2021-07-25 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 17:44 [PATCH for-6.1 0/2] accel/tcg: Fix hang when running in icount mode Peter Maydell
2021-07-25 17:44 ` [PATCH for-6.1 1/2] accel/tcg: Don't use CF_COUNT_MASK as the max value of icount_decr.u16.low Peter Maydell
2021-07-26 9:17 ` Philippe Mathieu-Daudé
2021-07-25 17:44 ` [PATCH for-6.1 2/2] accel/tcg: Remove unnecessary check on icount_extra in cpu_loop_exec_tb() Peter Maydell
2021-07-25 17:45 ` Peter Maydell [this message]
2021-07-25 18:11 ` [PATCH for-6.1 0/2] accel/tcg: Fix hang when running in icount mode Richard Henderson
2021-07-26 16:54 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-yUhjXwK5yPm1-uPTO+KmC5Lyv5UQbA5S3qFhzQNo4nQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).