From: Peter Maydell <peter.maydell@linaro.org>
To: Andrew Baumann <Andrew.Baumann@microsoft.com>
Cc: "qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [Qemu-devel] [PATCH V2] bcm2835_property: implement "get board revision" query
Date: Tue, 9 Feb 2016 18:11:00 +0000 [thread overview]
Message-ID: <CAFEAcA81Pmi0a6saiy_Ff-ozmw4AJ6SBmW6JYR-DS86ERV004Q@mail.gmail.com> (raw)
In-Reply-To: <BLUPR0301MB2034738A097725F02E582A2A9ED60@BLUPR0301MB2034.namprd03.prod.outlook.com>
On 9 February 2016 at 05:41, Andrew Baumann
<Andrew.Baumann@microsoft.com> wrote:
>> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
>> Sent: Tuesday, 9 February 2016 3:59 PM
>>
>> Return a valid value from the BCM2835 property mailbox query "get board
>> revision". This query is used by U-Boot. Implementing it fixes the first
>> obvious difference between qemu and real HW.
>>
>> The value returned is currently hard-coded to match the RPi2 I own. Other
>> values are legal, e.g. different board manufacturer field values are likely to
>> exist in the wild.
>>
>> Cc: Andrew Baumann <Andrew.Baumann@microsoft.com>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>> V2: Set the property in raspi.c, and pass it through to the property mbox
>> code via property aliases.
>
> Reviewed-by: Andrew Baumann <Andrew.Baumann@microsoft.com>
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2016-02-09 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 4:58 [Qemu-devel] [PATCH V2] bcm2835_property: implement "get board revision" query Stephen Warren
2016-02-09 5:41 ` Andrew Baumann
2016-02-09 18:11 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA81Pmi0a6saiy_Ff-ozmw4AJ6SBmW6JYR-DS86ERV004Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).