From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B7EC433DF for ; Thu, 18 Jun 2020 13:44:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82D902082F for ; Thu, 18 Jun 2020 13:44:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="neU5bLcQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82D902082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jluqQ-0003tp-NH for qemu-devel@archiver.kernel.org; Thu, 18 Jun 2020 09:44:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jludy-0006s1-5m for qemu-devel@nongnu.org; Thu, 18 Jun 2020 09:31:50 -0400 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]:40822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jludv-0007iX-JP for qemu-devel@nongnu.org; Thu, 18 Jun 2020 09:31:49 -0400 Received: by mail-oi1-x242.google.com with SMTP id t25so5048416oij.7 for ; Thu, 18 Jun 2020 06:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fkjHCDpYTARpMaa7D3EA8CbN8CCSa+lbQaizLJq9WzQ=; b=neU5bLcQUTRTlbiT92KjLzVjMtyn9VDgYDJtL7V7VKulrYO0RQAPd7n8bpen501Ihy lfz3d5OejwmMdU67R/dxKyPpMpwd0sDxIPBEDX5wA072/pUHRnFEahxFMaKq5dZITcw2 lzX0jeGvTPaicf5WqjNleyF6ha7+UOg/JEuiusmn3A18iwL9vpCTjfxLglAGO9CcD8Q/ Sb7fvxCAaaPQMdZKFkvD2mwDwMkFzjzM9qiZULGW2FkTV5/3lbrKDi5tYorhh7MQ+IXW oKtmDLVeaUn9VrlEJNuYGpFSYAEJN6Q2VqOS0sqqjcQ4fqzPRbdicF+E+BnHs+U/G6W4 mMbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fkjHCDpYTARpMaa7D3EA8CbN8CCSa+lbQaizLJq9WzQ=; b=Vkg6/ggiKffUTr+LUf3biJIybrNa4DySlcBJDEDHIwIOER3S+xucXiVVzkRsLKEyAj 1lATKWGpur2bS5Na9qZp4Wm2YihOOcbfeE2HXn6mlr3QFF2QtQIA27HkSX4lF5MI6noQ esR36C6wjmW9grGsZzJ8DRA7GHhQra0+ySpm/Ul174LXFfYdykTTGHugk0JVmRk9y2Mv gFtLtsh1uWxWKfurcXWRO6YFmKipzCa17MX9qs3mvqGfZ2N8S848M19rthIl4TzVJ+Pu LIfk57aniaiaRils+NBl/MqLfvkW2TpYisChbX4vHYaaRHNiRZ6tUG5uepblGqJl75wV OmxA== X-Gm-Message-State: AOAM531Msty/ie6gT9b6NheqmFk5e4jdC2V+pEQmWOnANg0FpkofxoYe EU0Qbt/pXavd3yF6Fmv3UyszYi6jWykHrpP9znjpFw== X-Google-Smtp-Source: ABdhPJxdc4vAscDrz4EpncLc883tbRX4PBNAtjKSrJW5MHLHrQpcWrKqP0A69XxTDILsrOGPWfctYS5tQM5+gcgcL98= X-Received: by 2002:aca:5152:: with SMTP id f79mr2780017oib.146.1592487106235; Thu, 18 Jun 2020 06:31:46 -0700 (PDT) MIME-Version: 1.0 References: <20200603011317.473934-1-richard.henderson@linaro.org> <20200603011317.473934-14-richard.henderson@linaro.org> In-Reply-To: <20200603011317.473934-14-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 18 Jun 2020 14:31:35 +0100 Message-ID: Subject: Re: [PATCH v7 13/42] target/arm: Define arm_cpu_do_unaligned_access for user-only To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::242; envelope-from=peter.maydell@linaro.org; helo=mail-oi1-x242.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , Stephen Long Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > We need this to raise unaligned exceptions from user mode. > > Signed-off-by: Richard Henderson > --- > v6: Use EXCP_UNALIGNED for user-only and update cpu_loop.c. Could you update the comment in cpu.h, maybe something like: #define EXCP_UNALIGNED 22 /* v7M UNALIGNED UsageFault; also linux-user */ and also update the string printed by arm_log_exception(): #ifdef CONFIG_USER_ONLY [EXCP_UNALIGNED] = "linux-user unaligned access fault", #else [EXCP_UNALIGNED] = "v7M UNALIGNED UsageFault", #endif Otherwise Reviewed-by: Peter Maydell thanks -- PMM