From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDCAC433ED for ; Thu, 20 May 2021 15:47:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B81F46108D for ; Thu, 20 May 2021 15:47:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B81F46108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljkti-0001Ir-Mz for qemu-devel@archiver.kernel.org; Thu, 20 May 2021 11:47:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljkrP-0007vs-Dc for qemu-devel@nongnu.org; Thu, 20 May 2021 11:45:19 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:38642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljkrN-00088P-R2 for qemu-devel@nongnu.org; Thu, 20 May 2021 11:45:19 -0400 Received: by mail-ej1-x62b.google.com with SMTP id i7so8214912ejc.5 for ; Thu, 20 May 2021 08:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I6O8/L3ylxIpnQe9NkcAetgPjV6Xg3rsE+K/q/jQeh0=; b=W6ZmMg9qp+HDBXl8qWCRbf33Z0Zr/BeDF3LoknVn+sRmccnBbXG02UJGeAd1uRedVp quVN+N1t8bxON2jhn0dQH4eq70IYOGN+YhNZyWiYOd0GbHlcfJr+LrF0GAMYKoRuJvKW qkJABAqEHWqtEGXuQWMcGRoTv3aqAuNDCIuLKZ/9YfIwXJ4AFstIRNm6ZYax3HN6+nQQ QaK9ZRYBSnyKT7pF4zUw7hm6vry/cE7rlZzlwcXe+58wK6THCLm4GGmkOnsDvKBK1gQl wbxUmNNJnqSIPAItOrgthFehwLMqmTBdV/dCUM3/ZYp2lusLw+U252cocdhtvvSVKFZl zqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I6O8/L3ylxIpnQe9NkcAetgPjV6Xg3rsE+K/q/jQeh0=; b=G0WjGGUYwtzBlOiKJWEzyKFpZHdYUklM+ieE+MKcQIWtnOF1bstLxtE/ALujz3EdYP Pi3W2zhh/S/LbUnWM5wlntJNlYiHeF3S1Oiae9JYnhqhBgM1M81XvbetMSaNX+OybGxG BD35718U0kQK+DJ1q1YeuHQ3vTEYk2ywMxblN/YPEnkf+bbs7Vr1FC0orw9h5kz9E432 D4zstuqAM4ybEoVMOU+eeQJJBJYuBXRr3gUyGzw4UH4SFo75SHoHsBmIGdABLweAg62K 0dHKPVhUsLdOpjj5wKEbg9XDpZbF5134IAt4dCfIFks/KA+UAYveJHl9i1RbXQ5SWpam ibXA== X-Gm-Message-State: AOAM5328GfkAwNcyKtO1QsEASes6L5tEfsh87qT2L+ZCGeUL1r7HqMuJ NzF/tazm/mfdcZEoLsAzWZWuu3zZ/tLvxU9qGJBAnA== X-Google-Smtp-Source: ABdhPJyf5Iko/ZSQaNMbFugR2NCllk+1Pd5+ZGQ4nC1zryiiGaR+LQkKOESD1BKQ4oCHQmvozhUlvp7Cs9NxAUKJmgI= X-Received: by 2002:a17:906:d8cb:: with SMTP id re11mr5364132ejb.482.1621525516235; Thu, 20 May 2021 08:45:16 -0700 (PDT) MIME-Version: 1.0 References: <20210510124747.780877-1-eric.auger@redhat.com> In-Reply-To: <20210510124747.780877-1-eric.auger@redhat.com> From: Peter Maydell Date: Thu, 20 May 2021 16:44:57 +0100 Message-ID: Subject: Re: [PATCH v2] hw/arm/smmuv3: Another range invalidation fix To: Eric Auger Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kunkun Jiang , QEMU Developers , Peter Xu , qemu-arm , Shameerali Kolothum Thodi , Eric Auger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 10 May 2021 at 13:48, Eric Auger wrote: > > 6d9cd115b9 ("hw/arm/smmuv3: Enforce invalidation on a power of two range") > failed to completely fix misalignment issues with range > invalidation. For instance invalidations patterns like "invalidate 32 > 4kB pages starting from 0xff395000 are not correctly handled" due > to the fact the previous fix only made sure the number of invalidated > pages were a power of 2 but did not properly handle the start > address was not aligned with the range. This can be noticed when > boothing a fedora 33 with protected virtio-blk-pci. > > Signed-off-by: Eric Auger > Fixes: 6d9cd115b9 ("hw/arm/smmuv3: Enforce invalidation on a power of two range") > > --- Applied to target-arm.next, thanks. -- PMM