From: Peter Maydell <peter.maydell@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>
Cc: Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1
Date: Tue, 19 Nov 2019 19:31:28 +0000 [thread overview]
Message-ID: <CAFEAcA8AeTgY+3GaN9ZUi-5XtX5jxhqpdOhr3ixYwouWhQOQ5g@mail.gmail.com> (raw)
In-Reply-To: <1574190388-12605-1-git-send-email-tsimpson@quicinc.com>
On Tue, 19 Nov 2019 at 19:07, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> linux-user/signal.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 5ca6d62..ce3d27f 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -72,6 +72,14 @@ static uint8_t host_to_target_signal_table[_NSIG] = {
> over a single host signal. */
> [__SIGRTMIN] = __SIGRTMAX,
> [__SIGRTMAX] = __SIGRTMIN,
> +#ifdef TARGET_HEXAGON
> + /*
> + * Hexagon uses the same signal for pthread cancel as the host pthreads,
> + * so cannot be overridden.
> + * Therefore, we map Hexagon signal to a different host signal.
> + */
> + [__SIGRTMAX - 1] = __SIGRTMIN + 1,
> +#endif
> };
This breaks other stuff, unfortunately, like Go binaries.
(Also, you now have two host signals mapped to the same
target signal; notice that the existing RTMAX/RTMIN
is a swap of the two slots.)
We need a generic solution for this, Hexagon is not the
only one with the problem. There's a patchset on list
from ages back that had a suggested approach, but
it needed review and work.
thanks
-- PMM
next prev parent reply other threads:[~2019-11-19 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 19:06 [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1 Taylor Simpson
2019-11-19 19:31 ` Peter Maydell [this message]
2019-11-20 5:23 ` Taylor Simpson
2019-11-20 8:09 ` Laurent Vivier
2019-11-20 10:45 ` Peter Maydell
2019-11-20 10:54 ` Laurent Vivier
2019-11-20 11:00 ` Peter Maydell
2019-11-20 12:54 ` Taylor Simpson
2019-11-21 11:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8AeTgY+3GaN9ZUi-5XtX5jxhqpdOhr3ixYwouWhQOQ5g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).