From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRHj3-0000PV-1L
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:05:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRHj2-00080Q-2K
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:05:24 -0500
Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:35448)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRHj1-000808-Ki
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:05:23 -0500
Received: by mail-vk0-x234.google.com with SMTP id e6so33923395vkh.2
	for <qemu-devel@nongnu.org>; Thu, 04 Feb 2016 03:05:23 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <56B24BA0.2030307@redhat.com>
References: <1454514465-11856-1-git-send-email-stefanha@redhat.com>
	<CAFEAcA8uQavMyPxfgO8C3-=P6op=SFAb7SNJ4AQ0xi4aNa9YLA@mail.gmail.com>
	<56B24BA0.2030307@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 4 Feb 2016 11:05:03 +0000
Message-ID: <CAFEAcA8C9Bvsgvdv90nvTNT2CXF4JGXdeiCyEW54Dr3D03pd3A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PULL 00/13] Tracing patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On 3 February 2016 at 18:49, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 03/02/2016 18:55, Peter Maydell wrote:
>> On 3 February 2016 at 15:47, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>> I think this is a quirk of this elderly mingw setup that's come up
>> before, but I forget what the resolution of it was.
>> (I now have a more up to date mingw build in the mix too, so I'm
>> not completely averse to the suggestion of "drop this thing".)
>
> Looks like this was always broken, it just required some extra configure
> argument.
>
> I would "drop this thing" or, better, you could compile with
> "--enable-trace-backend=nop" on the old mingw setup and without it on
> the new one.  This has the additional advantage of better coverage.

I added this configure argument and the build does pass, so I've
pushed it to master. I probably will drop the build config
entirely at some point though, IIRC it doesn't actually build
working executables. It's kind of handy to have one elderly
gcc in the mix, though, as long as the mingw foibles don't
cause too much hassle.

thanks
-- PMM