qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PULL 0/3] MIPS patches for 2021-04-13
@ 2021-04-13 10:11 Philippe Mathieu-Daudé
  2021-04-13 10:11 ` [PULL 1/3] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Philippe Mathieu-Daudé
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-13 10:11 UTC (permalink / raw)
  To: qemu-devel
  Cc: Hervé Poussineau, Aleksandar Rikalo,
	Philippe Mathieu-Daudé,
	Aurelien Jarno

The following changes since commit c1e90def01bdb8fcbdbebd9d1eaa8e4827ece620:\r
\r
  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210412' into staging (2021-04-12 12:12:09 +0100)\r
\r
are available in the Git repository at:\r
\r
  https://github.com/philmd/qemu.git tags/mips-20210413\r
\r
for you to fetch changes up to f4349ba966abfe39f5d98694abd7c7551d5c8c02:\r
\r
  target/mips: Fix TCG temporary leak in gen_cache_operation() (2021-04-13 12:07:00 +0200)\r
\r
----------------------------------------------------------------\r
MIPS patches queue\r
\r
- Fix invalid Kconfig dependency\r
- Fix missing migrated value\r
- Fix TCG temporary leak\r
----------------------------------------------------------------\r
\r
Philippe Mathieu-Daudé (3):\r
  hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM\r
  hw/isa/piix4: Migrate Reset Control Register\r
  target/mips: Fix TCG temporary leak in gen_cache_operation()\r
\r
 hw/isa/piix4.c          | 15 ++++++++++++++-\r
 target/mips/translate.c |  2 ++\r
 hw/isa/Kconfig          |  1 +\r
 3 files changed, 17 insertions(+), 1 deletion(-)\r
\r
-- \r
2.26.3\r
\r


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PULL 1/3] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM
  2021-04-13 10:11 [PULL 0/3] MIPS patches for 2021-04-13 Philippe Mathieu-Daudé
@ 2021-04-13 10:11 ` Philippe Mathieu-Daudé
  2021-04-13 10:11 ` [PULL 2/3] hw/isa/piix4: Migrate Reset Control Register Philippe Mathieu-Daudé
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-13 10:11 UTC (permalink / raw)
  To: qemu-devel
  Cc: Aleksandar Rikalo, Philippe Mathieu-Daudé,
	Hervé Poussineau, Aurelien Jarno

TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
requires APM to be selected.

Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Fixes: dd0ff8191ab ("isa: express SuperIO dependencies with Kconfig")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210302080531.913802-1-f4bug@amsat.org>
---
 hw/isa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 2691eae2f0c..55e0003ce40 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -48,6 +48,7 @@ config VT82C686
     select SERIAL_ISA
     select FDC
     select USB_UHCI
+    select APM
 
 config SMC37C669
     bool
-- 
2.26.3



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PULL 2/3] hw/isa/piix4: Migrate Reset Control Register
  2021-04-13 10:11 [PULL 0/3] MIPS patches for 2021-04-13 Philippe Mathieu-Daudé
  2021-04-13 10:11 ` [PULL 1/3] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Philippe Mathieu-Daudé
@ 2021-04-13 10:11 ` Philippe Mathieu-Daudé
  2021-04-13 10:11 ` [PULL 3/3] target/mips: Fix TCG temporary leak in gen_cache_operation() Philippe Mathieu-Daudé
  2021-04-13 15:50 ` [PULL 0/3] MIPS patches for 2021-04-13 Peter Maydell
  3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-13 10:11 UTC (permalink / raw)
  To: qemu-devel
  Cc: Aleksandar Rikalo, Philippe Mathieu-Daudé,
	Dr . David Alan Gilbert, Hervé Poussineau, Aurelien Jarno

When adding the Reset register in commit 5790b757cfb we
forgot to migrate it.

While it is possible a VM using the PIIX4 is migrated just
after requesting a system shutdown, it is very unlikely.
However when restoring a migrated VM, we might have the
RCR bit #4 set on the stack and when the VM resume it
directly shutdowns.

Add a post_load() migration handler and set the default
RCR value to 0 for earlier versions, assuming the VM was
not going to shutdown before migration.

Fixes: 5790b757cfb ("piix4: Add the Reset Control Register")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20210324200334.729899-1-f4bug@amsat.org>
---
 hw/isa/piix4.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index a50d97834c7..b3b6a4378a3 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -93,12 +93,25 @@ static void piix4_isa_reset(DeviceState *dev)
     pci_conf[0xae] = 0x00;
 }
 
+static int piix4_ide_post_load(void *opaque, int version_id)
+{
+    PIIX4State *s = opaque;
+
+    if (version_id == 2) {
+        s->rcr = 0;
+    }
+
+    return 0;
+}
+
 static const VMStateDescription vmstate_piix4 = {
     .name = "PIIX4",
-    .version_id = 2,
+    .version_id = 3,
     .minimum_version_id = 2,
+    .post_load = piix4_ide_post_load,
     .fields = (VMStateField[]) {
         VMSTATE_PCI_DEVICE(dev, PIIX4State),
+        VMSTATE_UINT8_V(rcr, PIIX4State, 3),
         VMSTATE_END_OF_LIST()
     }
 };
-- 
2.26.3



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PULL 3/3] target/mips: Fix TCG temporary leak in gen_cache_operation()
  2021-04-13 10:11 [PULL 0/3] MIPS patches for 2021-04-13 Philippe Mathieu-Daudé
  2021-04-13 10:11 ` [PULL 1/3] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Philippe Mathieu-Daudé
  2021-04-13 10:11 ` [PULL 2/3] hw/isa/piix4: Migrate Reset Control Register Philippe Mathieu-Daudé
@ 2021-04-13 10:11 ` Philippe Mathieu-Daudé
  2021-04-13 15:50 ` [PULL 0/3] MIPS patches for 2021-04-13 Peter Maydell
  3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-13 10:11 UTC (permalink / raw)
  To: qemu-devel
  Cc: Aleksandar Rikalo, Richard Henderson, Philippe Mathieu-Daudé,
	Hervé Poussineau, Aurelien Jarno

Fix a TCG temporary leak when translating CACHE opcode.

Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210406202857.1440744-1-f4bug@amsat.org>
---
 target/mips/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index c518bf3963b..71fa5ec1973 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -12804,6 +12804,8 @@ static void gen_cache_operation(DisasContext *ctx, uint32_t op, int base,
     TCGv t1 = tcg_temp_new();
     gen_base_offset_addr(ctx, t1, base, offset);
     gen_helper_cache(cpu_env, t1, t0);
+    tcg_temp_free(t1);
+    tcg_temp_free_i32(t0);
 }
 
 #if defined(TARGET_MIPS64)
-- 
2.26.3



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PULL 0/3] MIPS patches for 2021-04-13
  2021-04-13 10:11 [PULL 0/3] MIPS patches for 2021-04-13 Philippe Mathieu-Daudé
                   ` (2 preceding siblings ...)
  2021-04-13 10:11 ` [PULL 3/3] target/mips: Fix TCG temporary leak in gen_cache_operation() Philippe Mathieu-Daudé
@ 2021-04-13 15:50 ` Peter Maydell
  3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2021-04-13 15:50 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Aleksandar Rikalo, Hervé Poussineau, QEMU Developers,
	Aurelien Jarno

On Tue, 13 Apr 2021 at 11:13, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The following changes since commit c1e90def01bdb8fcbdbebd9d1eaa8e4827ece620:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210412' into staging (2021-04-12 12:12:09 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/philmd/qemu.git tags/mips-20210413
>
> for you to fetch changes up to f4349ba966abfe39f5d98694abd7c7551d5c8c02:
>
>   target/mips: Fix TCG temporary leak in gen_cache_operation() (2021-04-13 12:07:00 +0200)
>
> ----------------------------------------------------------------
> MIPS patches queue
>
> - Fix invalid Kconfig dependency
> - Fix missing migrated value
> - Fix TCG temporary leak


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-13 15:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 10:11 [PULL 0/3] MIPS patches for 2021-04-13 Philippe Mathieu-Daudé
2021-04-13 10:11 ` [PULL 1/3] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Philippe Mathieu-Daudé
2021-04-13 10:11 ` [PULL 2/3] hw/isa/piix4: Migrate Reset Control Register Philippe Mathieu-Daudé
2021-04-13 10:11 ` [PULL 3/3] target/mips: Fix TCG temporary leak in gen_cache_operation() Philippe Mathieu-Daudé
2021-04-13 15:50 ` [PULL 0/3] MIPS patches for 2021-04-13 Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).