qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 0/4] Improve reporting of ROM blob overlap errors
Date: Fri, 11 Dec 2020 14:08:45 +0000	[thread overview]
Message-ID: <CAFEAcA8LHbfZHRvYAE7c7=nMt5xe1R8Qpc-B5riRFxd7NK-0Uw@mail.gmail.com> (raw)
In-Reply-To: <20201129203923.10622-1-peter.maydell@linaro.org>

On Sun, 29 Nov 2020 at 20:39, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> (This was inspired by a conversation on IRC with a user.)
>
> We report an error if we detect that there's an overlap in guest
> memory between two ROM blobs, but the warning is pretty opaque.
> Currently it looks like this:
>
> rom: requested regions overlap (rom dtb. free=0x0000000000008000, addr=0x0000000000000000)
> qemu-system-aarch64: rom check and register reset failed
>
> which is pretty cryptic and also is missing information that we
> could fairly easily tell the user (like the name of both the ROMs
> involved in the overlap rather than just one of them...)
>
>
> After this patchset it looks like:
>
> qemu-system-aarch64: Some ROM regions are overlapping
> These ROM regions might have been loaded by direct user request or by default.
> They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded into guest memory.
> Check whether you intended to load all this guest code, and whether it has been built to load to the correct addresses.
>
> The following two regions overlap (in the cpu-memory-0 address space):
>   /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf ELF program header segment 0 (addresses 0x0000000000000000 - 0x0000000000008000)
>   dtb (addresses 0x0000000000000000 - 0x0000000000100000)
>
> The following two regions overlap (in the cpu-memory-0 address space):
>   /home/petmay01/linaro/qemu-misc-tests/bad-psci-call.axf ELF program header segment 1 (addresses 0x0000000040000000 - 0x0000000040000010)
>   /home/petmay01/linaro/qemu-misc-tests/bp-test.elf ELF program header segment 0 (addresses 0x0000000040000000 - 0x0000000040000020)
>

I'm going to take this series via target-arm.next.


thanks
-- PMM


      parent reply	other threads:[~2020-12-11 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 20:39 [PATCH 0/4] Improve reporting of ROM blob overlap errors Peter Maydell
2020-11-29 20:39 ` [PATCH 1/4] hw/core/loader.c: Track last-seen ROM in rom_check_and_register_reset() Peter Maydell
2020-11-30 18:23   ` Richard Henderson
2020-11-29 20:39 ` [PATCH 2/4] hw/core/loader.c: Improve reporting of ROM overlap errors Peter Maydell
2020-11-30 18:26   ` Richard Henderson
2020-11-29 20:39 ` [PATCH 3/4] elf_ops.h: Don't truncate name of the ROM blobs we create Peter Maydell
2020-11-30 18:26   ` Richard Henderson
2020-11-29 20:39 ` [PATCH 4/4] elf_ops.h: Be more verbose with ROM blob names Peter Maydell
2020-11-30 18:27   ` Richard Henderson
2020-12-11 14:08 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8LHbfZHRvYAE7c7=nMt5xe1R8Qpc-B5riRFxd7NK-0Uw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).