From: Peter Maydell <peter.maydell@linaro.org>
To: Alexander Graf <agraf@csgraf.de>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Zenghui Yu" <yuzenghui@huawei.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cornelia Huck" <cohuck@redhat.com>
Subject: Re: [PATCH v3 0/2] hw/arm/virt: Handle HVF in finalize_gic_version()
Date: Tue, 24 Jan 2023 16:47:23 +0000 [thread overview]
Message-ID: <CAFEAcA8Mk_E7e5dYZoC3qzm4DV2Brdqj4Of_VkaxDfe4wSV-ug@mail.gmail.com> (raw)
In-Reply-To: <20221223090107.98888-1-agraf@csgraf.de>
On Fri, 23 Dec 2022 at 09:01, Alexander Graf <agraf@csgraf.de> wrote:
>
> The finalize_gic_version() function tries to determine which GIC version
> the current accelerator / host combination supports. During the initial
> HVF porting efforts, I didn't realize that I also had to touch this
> function. Then Zenghui brought up this function as reply to my HVF GICv3
> enablement patch - and boy it is a mess.
>
> This patch set cleans up all of the GIC finalization so that we can
> easily plug HVF in and also hopefully will have a better time extending
> it in the future. As second step, it explicitly adds HVF support and
> fails loudly for any unsupported accelerators.
>
> Alex
>
> v1 -> v2:
>
> - Leave VIRT_GIC_VERSION defines intact, we need them for MADT generation
> - Include TCG header for tcg_enabled()
>
> v2 -> v3:
>
> - Fix comment
> - Flip kvm-enabled logic for host around
>
> Alexander Graf (2):
> hw/arm/virt: Consolidate GIC finalize logic
> hw/arm/virt: Make accels in GIC finalize logic explicit
Since AIUI these patches depend on "hvf: arm: Add support for GICv3",
would you mind including these when you respin that one (ie make
a series-of-3-patches)? That way I don't need to keep this series
on my to-review queue just because it's blocked on another patch :-)
thanks
-- PMM
next prev parent reply other threads:[~2023-01-24 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 9:01 [PATCH v3 0/2] hw/arm/virt: Handle HVF in finalize_gic_version() Alexander Graf
2022-12-23 9:01 ` [PATCH v3 1/2] hw/arm/virt: Consolidate GIC finalize logic Alexander Graf
2022-12-23 12:30 ` Cornelia Huck
2022-12-23 16:37 ` Alexander Graf
2023-01-11 13:35 ` Zenghui Yu via
2022-12-23 9:01 ` [PATCH v3 2/2] hw/arm/virt: Make accels in GIC finalize logic explicit Alexander Graf
2023-01-11 13:35 ` Zenghui Yu via
2023-01-17 7:34 ` Philippe Mathieu-Daudé
2022-12-24 23:38 ` [PATCH v3 0/2] hw/arm/virt: Handle HVF in finalize_gic_version() Richard Henderson
2023-01-24 16:47 ` Peter Maydell [this message]
2023-02-02 17:57 ` Peter Maydell
2023-02-03 7:07 ` Philippe Mathieu-Daudé
2023-02-03 10:24 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Mk_E7e5dYZoC3qzm4DV2Brdqj4Of_VkaxDfe4wSV-ug@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agraf@csgraf.de \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).