From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSpso-0001Of-AM
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:45:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSpsn-0000ly-6f
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:45:54 -0500
Received: from mail-vk0-x22b.google.com ([2607:f8b0:400c:c05::22b]:35520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSpsm-0000lt-TT
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:45:53 -0500
Received: by mail-vk0-x22b.google.com with SMTP id e6so100154625vkh.2
	for <qemu-devel@nongnu.org>; Mon, 08 Feb 2016 09:45:52 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <87bn7rrtib.fsf@blackfin.pond.sub.org>
References: <1454945806-14090-1-git-send-email-eblake@redhat.com>
	<87bn7rrtib.fsf@blackfin.pond.sub.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 8 Feb 2016 17:45:32 +0000
Message-ID: <CAFEAcA8QWDD_8KG_An-jDSg5q+pTBKG-eO=mSYmCRda05dhHBg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>

On 8 February 2016 at 17:39, Markus Armbruster <armbru@redhat.com> wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> As a followup to commit cbf2115, clean up the includes in files
>> generated by QAPI so that osdep.h is included first in .c files,
>> and headers which it implies are not included manually.  This
>> patch is done manually, since Coccinelle (and therefore
>> scripts/clean-includes) doesn't see into the generator scripts.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>
>   CC    tests/check-qfloat.o
> In file included from /home/armbru/work/qemu/include/qapi/qmp/qobject.h:3=
7:0,
>                  from /home/armbru/work/qemu/include/qapi/qmp/qfloat.h:18=
,
>                  from /home/armbru/work/qemu/tests/check-qfloat.c:15:
> ./qapi-types.h:55:9: error: unknown type name =E2=80=98bool=E2=80=99
>          bool value;
>          ^
>
> Chicken and egg problem?  check-qfloat.c doesn't include osdep.h, yet...

Easy enough to add it; I have 'run clean-includes on tests/' on
my todo list, but it requires a little care because I think at
least some .c files in tests/ do not have QEMU headers in their
include path at all. This might just be tests/tcg/.

thanks
-- PMM