From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A18EC433ED for ; Fri, 30 Apr 2021 22:59:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D72A613B1 for ; Fri, 30 Apr 2021 22:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D72A613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcc71-0006wG-H3 for qemu-devel@archiver.kernel.org; Fri, 30 Apr 2021 18:59:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcc5o-0006Xb-PM for qemu-devel@nongnu.org; Fri, 30 Apr 2021 18:58:40 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:35549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcc5n-0000VW-26 for qemu-devel@nongnu.org; Fri, 30 Apr 2021 18:58:40 -0400 Received: by mail-ej1-x62c.google.com with SMTP id u17so107626403ejk.2 for ; Fri, 30 Apr 2021 15:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4DK9gMqtb+maJw2WuB0jtYlj9eVQuccew2j0oi3l314=; b=jp0mmutU6GNfjZNWPKd6wi7p/Hf18ee38ENEzhhFHRUopLd4bQI6w0XZOHh/ZObwMN RKq+XYke5CS/BPec54uQjgBWjObv68uI569aJea1jwxwxuOif+ve2UsIDPPO1DsobfTU +rm+0o08kcOvf4r+UolEQAHSo3cQNV7CFYKDpO/qdkyHoKwHQhZczzkvlvFaMFx+2M9v 8mk+YpuiFVmre5XdDE9LxuMGwHxxcKXwp4fk5qk7ba2SJ5yEWdYWqB2+RQPfa/8Wk/Di gfHzmmE2Sr5g8B0dHwXWlPWriw4kJkTLVx9iYmOchhk3yUTcqy/K/GscpyHLyh7kt5Mj x7ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4DK9gMqtb+maJw2WuB0jtYlj9eVQuccew2j0oi3l314=; b=hLaqyFDgPX9O+QsKk+8xaUuckYagPOtBTmPEJ0p3NMyeAYTAA6oyrH/evfGbLWkH3E 0HL5peaeZaWEhpEw7wqMNsRiN3WfiXdEUsNjxc2Rbl2/EdaEsIUH+1w+n/xNOPQ4TFyN EAiazH5nxWy7rwuK9oucQuVRE6tmktdFa0ZuRFXbXpEgWX4Kg7mfzGsZXNOMnsVbxTOD hS/6VLwoa1sa+d81VSk+wDSswCxG8bjLfVTpIH9VIgQH6JBSBdTdUSA2+PpDE24mXzen S4KAknJc+UynFaZDMA5QvyWsAG7MtmU3xlVvap9A9E7QWQbcS03VypVA46An0+olTCTs BnHA== X-Gm-Message-State: AOAM531zQv7uKERkAtG3UM3SI8fzdpcksqSvdkUtHOgH6FSvMR+fxnxO OJz8w2QNbkbMwKewHk0DLWbyoZMMxCJDZfPd1BDpkg== X-Google-Smtp-Source: ABdhPJxasP1+cuWcPBZKhj4e0bY3BHtDm9Bicc8/WEZlIRxrut+BfVcGJEVTCok/0LxsH2GypHBmDHF9hZWT7RlEsTw= X-Received: by 2002:a17:906:11cc:: with SMTP id o12mr6850727eja.85.1619823517193; Fri, 30 Apr 2021 15:58:37 -0700 (PDT) MIME-Version: 1.0 References: <20200122111517.33223-1-quintela@redhat.com> <20200122111517.33223-5-quintela@redhat.com> In-Reply-To: <20200122111517.33223-5-quintela@redhat.com> From: Peter Maydell Date: Fri, 30 Apr 2021 23:57:34 +0100 Message-ID: Subject: Re: [PATCH v4 4/6] migration-test: Make sure that multifd and cancel works To: Juan Quintela Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , QEMU Developers , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 22 Jan 2020 at 11:20, Juan Quintela wrote: > > Test that this sequerce works: > > - launch source > - launch target > - start migration > - cancel migration > - relaunch target > - do migration again > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela A year-old commit, but we've just got around to running Coverity on the tests/ directory, and it spotted this one: > static void migrate_set_capability(QTestState *who, const char *capability, > bool value) The 3rd argument to migrate_set_capability() is a bool... > +static void test_multifd_tcp_cancel(void) > +{ > + migrate_set_parameter_int(from, "downtime-limit", 1); > + /* 300MB/s */ > + migrate_set_parameter_int(from, "max-bandwidth", 30000000); > + > + migrate_set_parameter_int(from, "multifd-channels", 16); > + migrate_set_parameter_int(to, "multifd-channels", 16); > + > + migrate_set_capability(from, "multifd", "true"); > + migrate_set_capability(to, "multifd", "true"); ...but here you pass it the character string '"true"' rather than the boolean value 'true'. This works by fluke since the implicit comparison of the literal string against NULL will evaluate to true, but it isn't really right :-) CID 1432373, 1432292, 1432288. There seem to be 7 uses of the string "true" when the boolean was intended; I don't know why Coverity only found 3 issues. thanks -- PMM