From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38933)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRjAw-0002cN-6r
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:24:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRjAv-0007wS-C5
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:24:02 -0500
Received: from mail-vk0-x229.google.com ([2607:f8b0:400c:c05::229]:33739)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRjAv-0007wO-7r
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:24:01 -0500
Received: by mail-vk0-x229.google.com with SMTP id e64so60052254vkg.0
	for <qemu-devel@nongnu.org>; Fri, 05 Feb 2016 08:24:01 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CANLssssdY6UFZozNtajrjuZpH4vWRMSCp4BDNuSXjGVfATsY4w@mail.gmail.com>
References: <CANLssst0zPbWbH1KDgK__d1kW3B=TSJknKrFAXUXKKuKR3-ubg@mail.gmail.com>
	<CAFEAcA8dZOGsEZ3smegTeiAZgGBMpkXZDymZwfScGJvBifFEFg@mail.gmail.com>
	<CANLsssumQX9muKaKdArYDV=ex_=tTGexS=jJd_OA_uh+KQvDdQ@mail.gmail.com>
	<CANLssssdY6UFZozNtajrjuZpH4vWRMSCp4BDNuSXjGVfATsY4w@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 5 Feb 2016 16:23:41 +0000
Message-ID: <CAFEAcA8ZJjDnFCYMG0aidhAb4obfbBTYy5oJ60e0pQqfBCoG=w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] Memory on stellaris board
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelio Remonda <aurelio.remonda@tallertechnologies.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 5 February 2016 at 16:09, Aurelio Remonda
<aurelio.remonda@tallertechnologies.com> wrote:
> Hello, im working on this feature right now.
> i have a working patch but maybe I can make some changes to make it look better:
> for example in some point i check ram_size like this:
> if (ram_size == 0x8000000)
> Maybe if i make ram_addr_t default_ram_size global (is a local
> variable of set_memory_options function)
> i can use it instead of hardcoded 0x8000000.

No, don't do that.

Why do you care about whether the ram size is the default or not?

thanks
-- PMM