From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DB2C07E95 for ; Fri, 16 Jul 2021 16:41:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D411613D0 for ; Fri, 16 Jul 2021 16:41:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D411613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4Qtk-0002a0-7x for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 12:41:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4Qso-0001ZG-Mn for qemu-devel@nongnu.org; Fri, 16 Jul 2021 12:40:14 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:40955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4Qsn-0003Pl-2O for qemu-devel@nongnu.org; Fri, 16 Jul 2021 12:40:14 -0400 Received: by mail-ed1-x52a.google.com with SMTP id t3so13715398edc.7 for ; Fri, 16 Jul 2021 09:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F7nZhr8OL4/8cjX9uRq9EBoz3R0CDrLz+eqwL0azsoM=; b=nzhRnc6Gztzap8K41c2OH1EWuo8tuIyHwP4DsvCBK8rNY/rTDqXth+rdxGtPnRwbzM DlQ41FD0zNg6I1N8TyNCTw2lTrLv+ePDYSOLqEBD4krEojIH/hBZbkEslzdoX6Bq3Apo Nnh4Zd0S0j/d634Wa/BTka6NAz6axNPnd0EjwYXO6esavoT5RWn88pgMNF7ipjrKHhEq 3jiBgzr3F8NF+JgfDgz204tm6VUgETSgKlbElUoFj4uA7Q3bzKelOB4CaB01PvC9I6bi DCJc7iqYPdqJft6EEmCo4Su4bt7xQc077sTuqIHBSZdY/OOCXvi3YgytKl06YvbUyom9 CJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F7nZhr8OL4/8cjX9uRq9EBoz3R0CDrLz+eqwL0azsoM=; b=PH5Xmk2jH/HvljgMlkgPKtTonzoot6OAZyg+bMxA1Os4bioXFqhpRnKyqpqFr44+Xw WeUSCPqWodL6ORdYP7rF/4m0e76YTTseMeQGd+AAZeI4scjJTps+m/gcY4sd8BZpv/oe 6MQoiIbZiB4YkSzhJ1JNL7P6mw2PFpQtDsP5DckSkDDdmLVnnDvlpKH1p/nUZMe/bNM7 4n8NYdPhXMl8FB7at9Dqu8Ig66YHEyS0QfPgm0fTqngTMyFov/VJZtgW61Br61GthvYu 6x2RiMkLKmK0wHlMtwvhDOw0vC2cdQZXltBW9Tl6hpC3u39BXUJpc28l86tQ0RoCZONm 6urA== X-Gm-Message-State: AOAM5314TdJlbP0ioSofltfGWqpeZg8IZKcbjM3R0VEroc2pElDHVq+R u87TqKvtPKovOBEtHpwK7wi4fJIPKmEkAV0EGM6XVA== X-Google-Smtp-Source: ABdhPJwPjuaasv9vfNIJUIW0QiuRyuutgi2C6bhRxtkle0FfOixtAwvDlCwYCrxt2IVBANufXPmtaaofnije/9a+0nM= X-Received: by 2002:a05:6402:697:: with SMTP id f23mr15714069edy.44.1626453608200; Fri, 16 Jul 2021 09:40:08 -0700 (PDT) MIME-Version: 1.0 References: <20210713133726.26842-1-peter.maydell@linaro.org> <20210713133726.26842-7-peter.maydell@linaro.org> <0332b682-1bd0-ca64-65f6-e06e1ad9c0bb@linaro.org> In-Reply-To: <0332b682-1bd0-ca64-65f6-e06e1ad9c0bb@linaro.org> From: Peter Maydell Date: Fri, 16 Jul 2021 17:39:28 +0100 Message-ID: Subject: Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 16 Jul 2021 at 17:34, Richard Henderson wrote: > > On 7/13/21 6:36 AM, Peter Maydell wrote: > > - return (1ULL << 47) - (src >= 0); > > + return sextract64((1ULL << 47) - (src >= 0), 0, 48); > > Clearer as > > return src >= 0 ? MAKE_64BIT_MASK(0, 47) : MAKE_64BIT_MASK(47, 17); Yeah, agreed. thanks -- PMM