qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Joelle van Dyne <j@getutm.app>
Cc: Kevin Wolf <kwolf@redhat.com>, Warner Losh <imp@bsdimp.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"open list:raw" <qemu-block@nongnu.org>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use
Date: Tue, 9 Mar 2021 11:31:20 +0000	[thread overview]
Message-ID: <CAFEAcA8c9=CYM2FfGf51-8keC8Gp2ySKMnXQ+YUz+Lw6g+Ek-g@mail.gmail.com> (raw)
In-Reply-To: <20210309002741.85057-4-j@getutm.app>

On Tue, 9 Mar 2021 at 00:30, Joelle van Dyne <j@getutm.app> wrote:
>
> iOS hosts do not have these defined so we fallback to the
> default behaviour.
>
> Co-authored-by: Warner Losh <imp@bsdimp.com>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
>  block/file-posix.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)

raw_getlength() is a bit of a mess; this certainly seems like
an improvement...

> diff --git a/block/file-posix.c b/block/file-posix.c
> index d1ab3180ff..9b6d7ddda3 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -2326,8 +2326,10 @@ static int64_t raw_getlength(BlockDriverState *bs)
>  again:
>  #endif
>      if (!fstat(fd, &sb) && (S_IFCHR & sb.st_mode)) {
> +        size = 0;
>  #ifdef DIOCGMEDIASIZE
>          if (ioctl(fd, DIOCGMEDIASIZE, (off_t *)&size))
> +            size = 0;

this if() should have braces {}.

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM


  reply	other threads:[~2021-03-09 11:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  0:27 [PATCH v2 0/4] Disable unsupported features on iOS hosts Joelle van Dyne
2021-03-09  0:27 ` [PATCH v2 1/4] block: feature detection for host block support Joelle van Dyne
2021-03-09  0:27 ` [PATCH v2 2/4] block: check for sys/disk.h Joelle van Dyne
2021-03-09 11:25   ` Peter Maydell
2021-03-09 12:09   ` Philippe Mathieu-Daudé
2021-03-09  0:27 ` [PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use Joelle van Dyne
2021-03-09 11:31   ` Peter Maydell [this message]
2021-03-09  0:27 ` [PATCH v2 4/4] slirp: feature detection for smbd Joelle van Dyne
2021-03-09 10:10   ` Peter Maydell
2021-03-09 12:12   ` Philippe Mathieu-Daudé
2021-03-09 14:09   ` Philippe Mathieu-Daudé
2021-03-09 18:11     ` Joelle van Dyne
2021-03-10  1:13       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8c9=CYM2FfGf51-8keC8Gp2ySKMnXQ+YUz+Lw6g+Ek-g@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=imp@bsdimp.com \
    --cc=j@getutm.app \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).