From: Peter Maydell <peter.maydell@linaro.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: Alistair Francis <alistair23@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v6 4/4] hw/arm: Add the Netduino Plus 2
Date: Tue, 17 Dec 2019 16:03:42 +0000 [thread overview]
Message-ID: <CAFEAcA8rZtJQsUXJ1E1gOAXzrHihzYvMoodgHhpro1Jd7jkVUg@mail.gmail.com> (raw)
In-Reply-To: <40f97ae32a6f21d8184c1cc46fad2defb302238d.1576227325.git.alistair@alistair23.me>
On Sat, 14 Dec 2019 at 02:44, Alistair Francis <alistair@alistair23.me> wrote:
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> MAINTAINERS | 6 +++++
> hw/arm/Kconfig | 3 +++
> hw/arm/Makefile.objs | 1 +
> hw/arm/netduinoplus2.c | 52 ++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 62 insertions(+)
> create mode 100644 hw/arm/netduinoplus2.c
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 7bfdc3a7ac..881e7f56e7 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -105,6 +105,9 @@ config NETDUINOPLUS2
> bool
> select STM32F405_SOC
>
> +config NETDUINOPLUS2
> + bool
> +
> config NSERIES
> bool
> select OMAP
Something odd has happened here -- your patch 1/4 already
had a stanza:
+config NETDUINOPLUS2
+ bool
+ select STM32F405_SOC
so either that should be in this patch or this fragment here
should just be deleted.
Assuming you sort that out,
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2019-12-17 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 2:44 [PATCH v6 0/4] Add the STM32F405 and Netduino Plus 2 machine Alistair Francis
2019-12-14 2:44 ` [PATCH v6 1/4] hw/misc: Add the STM32F4xx Sysconfig device Alistair Francis
2019-12-14 2:44 ` [PATCH v6 2/4] hw/misc: Add the STM32F4xx EXTI device Alistair Francis
2019-12-14 13:49 ` Philippe Mathieu-Daudé
2019-12-18 4:04 ` Alistair Francis
2019-12-14 2:44 ` [PATCH v6 3/4] hw/arm: Add the STM32F4xx SoC Alistair Francis
2019-12-14 2:44 ` [PATCH v6 4/4] hw/arm: Add the Netduino Plus 2 Alistair Francis
2019-12-17 16:03 ` Peter Maydell [this message]
2019-12-18 4:13 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8rZtJQsUXJ1E1gOAXzrHihzYvMoodgHhpro1Jd7jkVUg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).