qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 0/5] docs/system: Document some arm board models
Date: Fri, 15 May 2020 11:23:17 +0100	[thread overview]
Message-ID: <CAFEAcA93bQOh12CPS8xp9Qc45YrPTVSLo6yQ6raQ0WitHR184A@mail.gmail.com> (raw)
In-Reply-To: <49f4fc6f-329b-9afc-92db-c59dd1ce67ea@redhat.com>

On Fri, 15 May 2020 at 10:05, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Sphinx consumes docs/system/$arch/$machine.rst files committed to the
> repository, and we don't need to build various qemu-system-arch to
> generate the documentation.
>
> If you work on a particular board, you might end up only building its
> corresponding qemu-system-ARCH. Maybe we can add an extra-pass once a
> binary is linked, and re-generate the docs/system/ARCH/$machine.rst
> files, so if you modified a board and its documentation placeholder in
> the code, when commiting your code change, you also have to commit the
> rst changes.

I'm not a huge fan of committing generated files to source control...
I think I'd prefer an approach that worked via some kind of
kerneldoc comments that we pull out and parse using the Sphinx
plugin we have for that. (There's more complication than that
but roughly I think that would be the kind of approach I'd like
to see.)

thanks
-- PMM


      reply	other threads:[~2020-05-15 10:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 15:18 [PATCH 0/5] docs/system: Document some arm board models Peter Maydell
2020-05-07 15:18 ` [PATCH 1/5] docs/system: Add 'Arm' to the Integrator/CP document title Peter Maydell
2020-05-14 13:54   ` Edgar E. Iglesias
2020-05-15  9:00   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 2/5] docs/system: Sort Arm board index into alphabetical order Peter Maydell
2020-05-14 13:54   ` Edgar E. Iglesias
2020-05-15  9:41   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 3/5] docs/system: Document Arm Versatile Express boards Peter Maydell
2020-05-14 13:55   ` Edgar E. Iglesias
2020-05-15  9:54   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 4/5] docs/system: Document the various MPS2 models Peter Maydell
2020-05-14 13:56   ` Edgar E. Iglesias
2020-05-15  9:55   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 5/5] docs/system: Document Musca boards Peter Maydell
2020-05-14 13:56   ` Edgar E. Iglesias
2020-05-15  7:56   ` Philippe Mathieu-Daudé
2020-05-15  8:48     ` Peter Maydell
2020-05-15  9:06       ` Philippe Mathieu-Daudé
2020-05-15  9:56   ` Alex Bennée
2020-05-14 13:28 ` [PATCH 0/5] docs/system: Document some arm board models Peter Maydell
2020-05-15  8:03   ` Philippe Mathieu-Daudé
2020-05-15  8:51     ` Peter Maydell
2020-05-15  9:05       ` Philippe Mathieu-Daudé
2020-05-15 10:23         ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA93bQOh12CPS8xp9Qc45YrPTVSLo6yQ6raQ0WitHR184A@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).