From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2] target/arm: Do not reject rt == rt2 for strexd
Date: Mon, 18 Nov 2019 13:17:18 +0000 [thread overview]
Message-ID: <CAFEAcA9A95+Nq7+YYZ4_gvg1_CFKRPR0-wGNdT8v524kqTyUJg@mail.gmail.com> (raw)
In-Reply-To: <20191117090621.32425-2-richard.henderson@linaro.org>
On Sun, 17 Nov 2019 at 09:06, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> There was too much cut and paste between ldrexd and strexd,
> as ldrexd does prohibit two output registers the same.
>
> Fixes: af288228995
> Reported-by: Michael Goffioul <michael.goffioul@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 2ea9da7637..b285b23858 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -8934,7 +8934,7 @@ static bool op_strex(DisasContext *s, arg_STREX *a, MemOp mop, bool rel)
> || (s->thumb && (a->rd == 13 || a->rt == 13))
> || (mop == MO_64
> && (a->rt2 == 15
> - || a->rd == a->rt2 || a->rt == a->rt2
> + || a->rd == a->rt2
> || (s->thumb && a->rt2 == 13)))) {
> unallocated_encoding(s);
> return true;
> --
> 2.17.1
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2019-11-18 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 9:06 [PATCH for-4.2 0/2] target/arm: two fixes for ldrex/strex Richard Henderson
2019-11-17 9:06 ` [PATCH 1/2] target/arm: Do not reject rt == rt2 for strexd Richard Henderson
2019-11-18 13:17 ` Peter Maydell [this message]
2019-11-17 9:06 ` [PATCH 2/2] target/arm: Relax r13 restriction for ldrex/strex for v8.0 Richard Henderson
2019-11-18 13:10 ` Peter Maydell
2019-11-18 13:15 ` Richard Henderson
2019-11-18 17:53 ` Peter Maydell
2019-11-18 20:02 ` Richard Henderson
2019-11-18 21:22 ` Peter Maydell
[not found] <SN6PR13MB2272A9BECAC02344BAEFDED5804C0@SN6PR13MB2272.namprd13.prod.outlook.com>
2019-11-19 13:08 ` [PATCH 1/2] target/arm: Do not reject rt == rt2 for strexd Robert Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9A95+Nq7+YYZ4_gvg1_CFKRPR0-wGNdT8v524kqTyUJg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).