From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Alistair Francis <alistair@alistair23.me>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Andrew Baumann <Andrew.Baumann@microsoft.com>
Subject: Re: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block
Date: Thu, 17 Oct 2019 17:23:12 +0100 [thread overview]
Message-ID: <CAFEAcA9DiMXu9a6nzSo4967y9G2E3tC8ijHF2=b6Kvpt=XeYEw@mail.gmail.com> (raw)
In-Reply-To: <20191007170646.14961-1-f4bug@amsat.org>
On Mon, 7 Oct 2019 at 18:06, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The BCM2838 has many more peripherals than his little brother,
> the BCM2837. With the raspi4, the Linux kernel takes more steps
> to configure the various MUXed devices. At some point it started
> to bug me, so I plan to add a dummy simple BCM2835_SPI block.
> It is cleaner to add it as a separate device than mixed with the
> AUX block. As a first step, split the UART block out.
>
> Since this part is self-contained and my raspi4 branch is getting
> too big, I'm sending it as a single series.
If you squash patches 1 and 2 together and avoid doing
things like renaming all the register offset constant
names (or, for stuff like fixing up comment syntax and
checkpatch nits, do them in a preparatory patch), then it
becomes somewhat easier to review, because then you can use
git diff --color-moved and can see easily that code has
only been moved to the other file without any accidental
extra changes.
thanks
-- PMM
prev parent reply other threads:[~2019-10-17 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:06 [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block Philippe Mathieu-Daudé
2019-10-07 17:06 ` [PATCH 1/3] hw/char: Add the BCM2835 miniuart Philippe Mathieu-Daudé
2019-10-11 22:05 ` Alistair Francis
2019-10-07 17:06 ` [PATCH 2/3] hw/char/bcm2835_aux: Use the BCM2835 miniuart block Philippe Mathieu-Daudé
2019-10-07 17:06 ` [PATCH 3/3] hw: Move BCM2835 AUX device from hw/char/ to hw/misc/ Philippe Mathieu-Daudé
2019-10-07 21:09 ` [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block no-reply
2019-10-17 16:23 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9DiMXu9a6nzSo4967y9G2E3tC8ijHF2=b6Kvpt=XeYEw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).