From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4681CC433E7 for ; Mon, 19 Oct 2020 15:26:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97C902231B for ; Mon, 19 Oct 2020 15:26:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kr5wNKDm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97C902231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUX3T-0006DM-J5 for qemu-devel@archiver.kernel.org; Mon, 19 Oct 2020 11:26:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUX0R-0002VV-BB for qemu-devel@nongnu.org; Mon, 19 Oct 2020 11:23:28 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:35624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUX0L-0003xq-CU for qemu-devel@nongnu.org; Mon, 19 Oct 2020 11:23:25 -0400 Received: by mail-ed1-x541.google.com with SMTP id cq12so10694709edb.2 for ; Mon, 19 Oct 2020 08:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rEF8vCp0ne68s88LSiZAalVd6SH2xeZNXOAKExoOtKE=; b=kr5wNKDm58CZNtiJgvXFBKp9c3+gbXYA62C3UKX153CcgyvaEFH5t2Jc6JO+3O7J6I 4BpYo4iLK1ZMb99ku2yfMys2bo5/ZtRRUdyvisTUJpr9HmIPTJxjLXBXWzLinZhPgiL0 AIMaSw0ENxU3tEctr6sHY/E63fzbO9tXLaIsn5z5mlSWBuDLz+8Kr5ZaVqKxtMEVsHp7 qAy08+fk9v4TZDWhsFNLFNe6ROKDTc0pLD4Ve7c678ei2f7cM5ch/l2/F+qjVuqx8OkZ cRnrAd6g5ZySAufzy5ziCqRBjfoTxzi016RnR9iimL6W98U6QXe4ln43PfC0tPA5TpFV oG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rEF8vCp0ne68s88LSiZAalVd6SH2xeZNXOAKExoOtKE=; b=Gj6nThL30mZwUMhGaCJbG79de2uYwOrsvqJFspHARXHq1mq4WYIsbKFmkplB0RbebV oukzyDwihPVDbt+phNsKcLejz9qT3tIfSJdMWiLBWeLo58kVv5mkxZnhYe+xqoFpz3EU w+shFybW2NOazvlyNZkRIVyc16+Q0jyZifQBH4RqdupnzgDZW/SFKvBNU60HoyK9kLi5 4Ff5pfVtT7SSV6iFFe6S2bsg5UEhvEIxdoOJewB1S262mAJRHW8I5F/WGV3LeVTjLQfw YeHKaxpatylZF22ay14djFYLpQM5x4byNP1w/US2CHk5ODe9iLEXtqi7E81uMupoQA1A 8SWA== X-Gm-Message-State: AOAM531Qv8VwBfcoy7QOcMRAcv3Dnuq4Aw3QRQe1/8+OLwmNi9eEbVXV dllDERDgVkihzlMKdVFua4EdyGQqDBMWd7RDVLy6sg== X-Google-Smtp-Source: ABdhPJwaSQo4DgM1Frso9tKu8F1xU24jTB4teY1uN4/mTvMq+DtdJ/YnxqhkFXaUcuzRT1YsqTZUpAF1kYgnpgah4mA= X-Received: by 2002:aa7:c7d7:: with SMTP id o23mr353827eds.44.1603120998221; Mon, 19 Oct 2020 08:23:18 -0700 (PDT) MIME-Version: 1.0 References: <20201014213601.205222-1-f4bug@amsat.org> In-Reply-To: <20201014213601.205222-1-f4bug@amsat.org> From: Peter Maydell Date: Mon, 19 Oct 2020 16:23:07 +0100 Message-ID: Subject: Re: [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::541; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x541.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 14 Oct 2020 at 22:36, Philippe Mathieu-Daud=C3=A9 = wrote: > > The time to transmit a char is expressed in nanoseconds, not in ticks. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/arm/strongarm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c > index d7133eea6f9..ca7c385f313 100644 > --- a/hw/arm/strongarm.c > +++ b/hw/arm/strongarm.c > @@ -935,7 +935,7 @@ struct StrongARMUARTState { > uint8_t rx_start; > uint8_t rx_len; > > - uint64_t char_transmit_time; /* time to transmit a char in ticks*/ > + uint64_t char_transmit_time; /* time to transmit a char in nanosecon= ds */ > bool wait_break_end; > QEMUTimer *rx_timeout_timer; > QEMUTimer *tx_timer; Applied to target-arm.next, thanks. -- PMM