From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSvMz-0003kJ-OP
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 18:37:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSvMy-0000F6-Uy
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 18:37:25 -0500
Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:35274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSvMy-0000El-Mq
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 18:37:24 -0500
Received: by mail-vk0-x22f.google.com with SMTP id e6so106294301vkh.2
	for <qemu-devel@nongnu.org>; Mon, 08 Feb 2016 15:37:24 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAKmqyKMMphHzbnxRDQHkH-=v5Ap_V3XfarKicF9h-Na5H1MZHQ@mail.gmail.com>
References: <1453479402-14870-1-git-send-email-peter.maydell@linaro.org>
	<1453479402-14870-5-git-send-email-peter.maydell@linaro.org>
	<CAKmqyKMMphHzbnxRDQHkH-=v5Ap_V3XfarKicF9h-Na5H1MZHQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 8 Feb 2016 23:37:04 +0000
Message-ID: <CAFEAcA9Mr8MstvOT+takGJG9T9+jdMiBdcm5HxmU49SoMzFDwg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 04/10] hw/sd: Add QOM bus which SD cards
 plug in to
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: Patch Tracking <patches@linaro.org>, Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Markus Armbruster <armbru@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Kevin O'Connor <kevin@koconnor.net>, qemu-arm <qemu-arm@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

On 8 February 2016 at 23:24, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> This patch doesn't compile and neither does anything after this. I get
> the following errors:
>
> In file included from hw/sd/sd.c:35:0:
> /work/alistai/master-qemu/include/hw/sd/sd.h:81:5: error: unknown type
> name =E2=80=98DeviceClass=E2=80=99
>      DeviceClass parent_class;
>      ^
> /work/alistai/master-qemu/include/hw/sd/sd.h:99:14: error: field
> =E2=80=98qbus=E2=80=99 has incomplete type
>      BusState qbus;
>               ^
> /work/alistai/master-qemu/include/hw/sd/sd.h:104:14: error: field
> =E2=80=98parent_class=E2=80=99 has incomplete type
>      BusClass parent_class;
>               ^
> /work/alistai/master-qemu/rules.mak:57: recipe for target 'hw/sd/sd.o' fa=
iled
> make: *** [hw/sd/sd.o] Error 1
> make: *** Waiting for unfinished jobs....

Weird. Maybe something's changed in include/ since I sent the series
so we're no longer getting qdev.h implicitly pulled in by some other
header.

Does adding #include "hw/qdev.h" before the sd.h include in
sd.c fix this?

thanks
-- PMM