From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B20C433E1 for ; Tue, 25 Aug 2020 12:40:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 194DF20738 for ; Tue, 25 Aug 2020 12:40:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AiIuX5l3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 194DF20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAYFE-0001uA-DI for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 08:40:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAYDu-0000Us-W6 for qemu-devel@nongnu.org; Tue, 25 Aug 2020 08:38:47 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:33865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAYDs-00076w-Ky for qemu-devel@nongnu.org; Tue, 25 Aug 2020 08:38:46 -0400 Received: by mail-ed1-x541.google.com with SMTP id bs17so11096261edb.1 for ; Tue, 25 Aug 2020 05:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qDG5L3tmh46vTBVfQ/EIwrsUYYSiNhJWo3VzF7A1D1I=; b=AiIuX5l3ntBuAlXo70yYuJf8yvChAMDx1Z4Y7wvIe54MPU4rHCqHa/Dd68RngNGD8w AOHzNmmr69vX7CyHG+J+w+q1Vjiq9Fq4eFV2v5pZDIPq8GdcQp1SRbOEvmNI+0qYoodM 9Fb+KzteYmA53A5V12dQ6yjPjO3BaWxRq2WkjWFDa3o92QZQDv/yHDRYPLLRwSdOc2lf umPDAtYEBfelTUpQOkcYP/+GNS74pNsescAwtzaBuLUve0f4b0kM6FbBSxLTDSHEJw2D Du3HM4zvPw3RH8CdSSd9fVWZr0C9qhzMfQSPcZLc7/AxjPReP2UEvg8dxjzu48zCJKx+ 8mMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qDG5L3tmh46vTBVfQ/EIwrsUYYSiNhJWo3VzF7A1D1I=; b=uLsEmZlTdFtF070kQqFQfeKUirx/GAVCMfPAif8oJHT4V0+qK1N/baO1wzyzZps16l qUeME+4z6pMx1rLzoEj+4L0QqnbK7YkggN7wjEBJWHkBC6GpjJyRvWeynqPpMO7F249Y YydVggyoeK9gWDPpgXS6KsdieGsWGn8AY6PX8MKfyECZ5G3Zclry7FJRCeH5oZnckyeg uyO9ljTVs5xp7dVPfTb4wkbqUumPGzXfyJNeGM7GDPu68gi+lVSIcwkZzT4FWVyt1U9K bDX/sVYJtkgQrdoUZmP/G4DiyKoxrMKU29PrS028WU64/GZhobMq1IIdqD/dzBmf3shW Gbog== X-Gm-Message-State: AOAM532yDapraF12IR5QOSjWM6akV8jLuP4kwjUhx94jSTg22Y9Z+snB t7ptg2so+OM3ecyf7A/4OJz1T+z486NttVyfQpPz7g== X-Google-Smtp-Source: ABdhPJwTWAtOrWlucsSPYm/WjLnJC7+NJCEo/fdjLbbPIaUp4NAi0TierA5jvjr/Yhk5Ad5ltKuOKyIwvbeHs05cQY8= X-Received: by 2002:a50:da44:: with SMTP id a4mr10308200edk.36.1598359123316; Tue, 25 Aug 2020 05:38:43 -0700 (PDT) MIME-Version: 1.0 References: <20200825112447.126308-1-kuhn.chenqun@huawei.com> <20200825112447.126308-5-kuhn.chenqun@huawei.com> In-Reply-To: <20200825112447.126308-5-kuhn.chenqun@huawei.com> From: Peter Maydell Date: Tue, 25 Aug 2020 13:38:32 +0100 Message-ID: Subject: Re: [PATCH v2 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() To: Chen Qun Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::541; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x541.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhanghailiang , QEMU Trivial , Pan Nengyuan , QEMU Developers , qemu-arm , Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 25 Aug 2020 at 12:26, Chen Qun wrote: > > Clang static code analyzer show warning: > target/arm/translate-a64.c:13007:5: warning: Value stored to 'rd' is never read > rd = extract32(insn, 0, 5); > ^ ~~~~~~~~~~~~~~~~~~~~~ > target/arm/translate-a64.c:13008:5: warning: Value stored to 'rn' is never read > rn = extract32(insn, 5, 5); > ^ ~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: Peter Maydell > Cc: qemu-arm@nongnu.org > --- > target/arm/translate-a64.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index c83bb85e4e..47cce160d8 100644 > --- a/target/arm/translate-a64.c > +++ b/target/arm/translate-a64.c > @@ -13016,9 +13016,6 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) > fpop = deposit32(opcode, 5, 1, a); > fpop = deposit32(fpop, 6, 1, u); > > - rd = extract32(insn, 0, 5); > - rn = extract32(insn, 5, 5); > - Reviewed-by: Peter Maydell thanks -- PMM