From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] ui/cocoa: Use kCGColorSpaceSRGB
Date: Fri, 19 Feb 2021 10:25:43 +0000 [thread overview]
Message-ID: <CAFEAcA9VGhEV=7YAEZQUdtukY=5Kfax9fmX_wj-UtjLN6JOfog@mail.gmail.com> (raw)
In-Reply-To: <20210219084518.90246-1-akihiko.odaki@gmail.com>
On Fri, 19 Feb 2021 at 08:45, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
> ui/cocoa.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 13fba8103e1..686fbb1b457 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -437,7 +437,7 @@ - (void) drawRect:(NSRect) rect
> screen.bitsPerPixel, //bitsPerPixel
> (screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
> #ifdef __LITTLE_ENDIAN__
> - CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4
> + CGColorSpaceCreateWithName(kCGColorSpaceSRGB), //colorspace for OS X >= 10.5
> kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
> #else
> CGColorSpaceCreateDeviceRGB(), //colorspace for OS X < 10.4 (actually ppc)
> --
The comment change here looks a little odd, because previously
it was a matched pair with the one in the other half of the #ifdef:
one side is "for OS X >= 10.4" and the other "for < 10.4". After
this change we have a mismatch. In fact it doesn't matter because
we don't support any OSX version that old any more anyway.
I think we should delete the whole #ifdef...#else...#endif block
here, and replace it with just the
CGColorSpaceCreateWithName(kCGColorSpaceSRGB),
kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
lines, because we dropped PPC support a long long time ago.
(And we don't need any comment about OSX version if we do that.)
thanks
-- PMM
next prev parent reply other threads:[~2021-02-19 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 8:45 [PATCH] ui/cocoa: Use kCGColorSpaceSRGB Akihiko Odaki
2021-02-19 10:25 ` Peter Maydell [this message]
2021-02-19 11:28 ` [PATCH v2] " Akihiko Odaki
2021-02-19 11:41 ` Peter Maydell
2021-02-19 14:11 ` Gerd Hoffmann
2021-02-20 4:29 ` [PATCH v3] " Akihiko Odaki
2021-02-22 10:36 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9VGhEV=7YAEZQUdtukY=5Kfax9fmX_wj-UtjLN6JOfog@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).