From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2728AC433E3 for ; Fri, 26 Mar 2021 10:24:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA82C61A0A for ; Fri, 26 Mar 2021 10:24:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA82C61A0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPje5-0004dZ-QE for qemu-devel@archiver.kernel.org; Fri, 26 Mar 2021 06:24:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPjaM-0001Ha-98 for qemu-devel@nongnu.org; Fri, 26 Mar 2021 06:20:58 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:37549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPjaK-0000Yy-CM for qemu-devel@nongnu.org; Fri, 26 Mar 2021 06:20:57 -0400 Received: by mail-ej1-x635.google.com with SMTP id w3so7603565ejc.4 for ; Fri, 26 Mar 2021 03:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5WJN03Ew2msb1e6JG5mzDx9NLkxyPo7Y/N/B9i/feOk=; b=VusCNDBKNMaFze7Lnutcw2psNPQnQi4TZB1Q06POW0V6gExS8mxK/491KtuIwefCyy H7hChsrh9Lh+xuP6VCDwoQr9mOniRYRHd+Ln9GycpZB9xvH5dP0XDT1AtKt4/YI4JZzs cS3QbfCVlySh4a+2o1vKwd0Vl8/d+yJF3YRsP0kRRoxUFz5qnFRBxzmFMcmwixjol+V7 wDIAlCELkWXvcALQhoTjmTjwv+eNWdCklJS8J9ZIWAd1KsBMXkIzWeEqZ/t2Kk+ulFlG G30asZ/ND8nT3ft+k1ChFq4MuZ2KcYEWe+1ewJ77t34xcA4BWyTycvKzqD4bL53VP1lG srCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5WJN03Ew2msb1e6JG5mzDx9NLkxyPo7Y/N/B9i/feOk=; b=pGkKhsGV8xwVmORhC3E1/BvUJSNlodH/5R3PW1SRAvDNiqrUj/acU9cCGbqAl+GjWR qYWKHi2nHl8XsOThecDWel/djHaLhXpujUCLxtYiH59hxMLdZH10qWlJyE3/vTF41Pzh jpFzjVEOBh3Q2jmrj2tYWpUBJPkBhM81oBOi5NfQkYtejVXTzCI1q4x8q6cRXEDV1QCq WGusFt2ReZw6WYfqGi/trQqm3EvK9L6iGUBJbHwA5LuicRHf6rHnJ/WJdlJrauYyhOVU AhPb/hjpvOAU6WM45XGaQHWLnh/wMNbL0UpSbhkR6a7ZsPvEqgn58WyyNBjQ/0N+gJLa 8zJA== X-Gm-Message-State: AOAM532ABBKuxQZ1jTirW2d+YVH7E34/m7/AXLe2CeDWIhaOyqp2pAId 6SlwT6MxnqZXFKVPbKIzfJLbiKIxNRUmmqWt4ziqvw== X-Google-Smtp-Source: ABdhPJws6FWSBH/yrJNI52CWe6GzlzX/nkox+RNtD8vpZSxL6eeNzthDEYM+yXZYsGvGxI26d4Qk3PyXaiWbIldnx0c= X-Received: by 2002:a17:906:8a65:: with SMTP id hy5mr14768445ejc.250.1616754054595; Fri, 26 Mar 2021 03:20:54 -0700 (PDT) MIME-Version: 1.0 References: <20210325153310.9131-1-peter.maydell@linaro.org> <20210325153310.9131-2-peter.maydell@linaro.org> In-Reply-To: From: Peter Maydell Date: Fri, 26 Mar 2021 10:20:22 +0000 Message-ID: Subject: Re: [PATCH for-6.0 1/4] include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev() To: Auger Eric Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Mark Cave-Ayland , Greg Kurz , QEMU Developers , qemu-arm , qemu-ppc , Igor Mammedov , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 26 Mar 2021 at 09:27, Auger Eric wrote: > > Hi Peter, > > On 3/25/21 4:33 PM, Peter Maydell wrote: > > The function machine_class_allow_dynamic_sysbus_dev() is currently > > undocumented; add a doc comment. > > > > Signed-off-by: Peter Maydell > > --- > > include/hw/boards.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index 4a90549ad85..27106abc11d 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -36,7 +36,21 @@ void machine_set_cpu_numa_node(MachineState *machine, > > const CpuInstanceProperties *props, > > Error **errp); > > > > +/** > > + * machine_class_allow_dynamic_sysbus_dev: Add type to list of valid devices > nit: s/of valid devices/of dynamically instantiable sysbus devices ? I was trying to keep the summary line to be one line, which doesn't give much space for nuance with a function name this long... -- PMM