From: Peter Maydell <peter.maydell@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>, "Li Qiang" <liq3ea@gmail.com>,
"Qemu Developers" <qemu-devel@nongnu.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 7/7] tests/fw_cfg: Run the tests on big-endian targets
Date: Tue, 8 Oct 2019 21:35:09 +0100 [thread overview]
Message-ID: <CAFEAcA9Xn=UTG7otjSX5e88ewVXmCmip=d=dvHwuM_jZ8X8QqQ@mail.gmail.com> (raw)
In-Reply-To: <f0178880-2526-c3ee-6ad5-1d66f2e23fd9@redhat.com>
On Tue, 8 Oct 2019 at 21:29, Laszlo Ersek <lersek@redhat.com> wrote:
> In that case, the original initializer will remain in effect, from:
>
> QTestCtx ctx = {};
>
> (Admittedly, this is an ugly GNU-ism; for standard C, it should be
>
> QTestCtx ctx = { 0 };
>
> but the GNU-ism is used quite frequently in QEMU elsewhere, so meh :) )
This is deliberate -- some compilers grumble about "{ 0 }" in
some situations, so we generally recommend using "{}" which
is accepted by all compilers we care about. (Cf commit message
for commit 039d4e3df0049bdd.)
thanks
-- PMM
next prev parent reply other threads:[~2019-10-08 20:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 15:18 [PATCH v2 0/7] fw_cfg: Run tests on big-endian Philippe Mathieu-Daudé
2019-10-07 15:18 ` [PATCH v2 1/7] tests/libqos/fw_cfg: Document io_fw_cfg_init to drop io_fw_cfg_uninit Philippe Mathieu-Daudé
2019-10-08 10:18 ` Li Qiang
2019-10-07 15:19 ` [PATCH v2 2/7] tests/libqos/fw_cfg: Document mm_fw_cfg_init to drop mm_fw_cfg_uninit Philippe Mathieu-Daudé
2019-10-08 10:20 ` Li Qiang
2019-10-07 15:19 ` [PATCH v2 3/7] tests/libqos/fw_cfg: Document pc_fw_cfg_init to drop pc_fw_cfg_uninit Philippe Mathieu-Daudé
2019-10-08 10:27 ` Li Qiang
2019-10-07 15:19 ` [PATCH v2 4/7] tests/fw_cfg: Let the tests use a context Philippe Mathieu-Daudé
2019-10-08 14:12 ` Li Qiang
2019-10-07 15:19 ` [PATCH v2 5/7] tests/libqos/fw_cfg: Pass QTestState as argument Philippe Mathieu-Daudé
2019-10-08 14:44 ` Li Qiang
2019-10-07 15:19 ` [PATCH v2 6/7] tests/fw_cfg: Declare one QFWCFG for all tests Philippe Mathieu-Daudé
2019-10-08 14:56 ` Li Qiang
2019-10-07 15:19 ` [PATCH v2 7/7] tests/fw_cfg: Run the tests on big-endian targets Philippe Mathieu-Daudé
2019-10-07 18:33 ` Laszlo Ersek
2019-10-08 15:04 ` Li Qiang
2019-10-08 15:14 ` Philippe Mathieu-Daudé
2019-10-08 15:56 ` Li Qiang
2019-10-08 20:27 ` Laszlo Ersek
2019-10-08 20:35 ` Peter Maydell [this message]
2019-10-09 0:35 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9Xn=UTG7otjSX5e88ewVXmCmip=d=dvHwuM_jZ8X8QqQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=liq3ea@gmail.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).