From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F78C433E0 for ; Tue, 2 Jun 2020 08:59:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E1B720734 for ; Tue, 2 Jun 2020 08:59:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WGdrOXgD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E1B720734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg2lI-0006vA-NT for qemu-devel@archiver.kernel.org; Tue, 02 Jun 2020 04:59:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg2kS-0006Sv-VW for qemu-devel@nongnu.org; Tue, 02 Jun 2020 04:58:16 -0400 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:44100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jg2kS-000757-1Q for qemu-devel@nongnu.org; Tue, 02 Jun 2020 04:58:16 -0400 Received: by mail-ot1-x342.google.com with SMTP id e5so2972659ote.11 for ; Tue, 02 Jun 2020 01:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iHO5jShazTDsI7/JF6fXAn1gfieZIHrI/ms3Fsh3d9I=; b=WGdrOXgDMPqchpBbxH4g1tixVwptD0nOMdka/aD2kiZn6SeZjzuYSaQZEnk77norkd WrR5XctNyjW2Djb87Poj5MV/LA8Lmmuo1JqLpLG0tJLo/KvBpRfVn2qwIGZeh7jSv9l2 7evKRmCK70Xh7vQfHQAdGFBwYoAdU6Ya2I8Zf1mujvw0ZjN3Fe6yP8x8JBcrnln8Z9n8 nIi+rGYLUqWW8uNZeWUlBkn/kb2Au9FkxjgqwYlEFIlXjA4vNAqn/rpEEWG6lQ7kW6Zb fDIo6K4OeKHyx2ULbQydIagvOYRnLwMh2K+/dzG3y58Nc8aOKeqCkxhAbVWpm15plG1G Jjjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iHO5jShazTDsI7/JF6fXAn1gfieZIHrI/ms3Fsh3d9I=; b=odHgfr9PZ7EsNFAODkQAwybseqI1VNYCjmn/NxtcQ517k9I9QrNQKkIalwgdokUWYX 6mPs2fFuY8zlHNbM7uy+XkqEY32sEnwKvlCPs12poCM45lBFcmt6Aesemgw7JI2NvgES sdCR4A6sU/BqMmHfeqofuwwAjRgTt0HM25I3aCEzZ45sIGkdzIutLl+ePah32v9NeVmS GlxwDMqsR8MF4mVT5rjXh2G9Y9DyUxYBrM5qNtUgZLjjzb2GtJyLXfmONBPZLFLlLbbe 5xLdRx9ZTGG+hg8EieSmqgcSkXOsmP8xqKv/wZQxeXlN5JKrovh9tGFi+Cm/47+3ka/S N/mQ== X-Gm-Message-State: AOAM532Xxt6l0m8wkOIfae1JJF6I+C28zJHzYIKmXzOiiTvP3fMnRzcX ++S2zXGqrMDxzo1LSIc8U/iKyKx4fhbTxk1N4YYQWQ== X-Google-Smtp-Source: ABdhPJwZe0IZJTdkEiMbRzIxJ4DlclFbJ1hNwEfvs/ooNRHeFQ6NE9yh5/Bbpwjw1dkTu1Wrvi6bmH2x0oox9pWVdFo= X-Received: by 2002:a05:6830:18da:: with SMTP id v26mr2772448ote.135.1591088294698; Tue, 02 Jun 2020 01:58:14 -0700 (PDT) MIME-Version: 1.0 References: <20200522145520.6778-1-peter.maydell@linaro.org> <20200522145520.6778-10-peter.maydell@linaro.org> In-Reply-To: From: Peter Maydell Date: Tue, 2 Jun 2020 09:58:02 +0100 Message-ID: Subject: Re: [PATCH v2 9/9] target/arm: Convert Neon one-register-and-immediate insns to decodetree To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::342; envelope-from=peter.maydell@linaro.org; helo=mail-ot1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 2 Jun 2020 at 00:32, Richard Henderson wrote: > It might be clearer to use dup_const for each case, which would more closely > match the pseudocode. E.g. here, > > return dup_const(MO_16, imm << 8); > > > + imm |= (imm << 8) | (imm << 16) | (imm << 24); > > return dup_const(MO_8, imm); Yeah, I did think about this, but figured that keeping the existing code structure was clearer for purposes of reviewing this refactoring series. thanks -- PMM