From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEE9C433E1 for ; Tue, 25 Aug 2020 12:38:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 069CF20738 for ; Tue, 25 Aug 2020 12:38:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X+DaCrsq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 069CF20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAYDm-0008O4-8A for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 08:38:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAYD8-0007fy-HW for qemu-devel@nongnu.org; Tue, 25 Aug 2020 08:37:58 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:44527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAYD6-000749-Cw for qemu-devel@nongnu.org; Tue, 25 Aug 2020 08:37:58 -0400 Received: by mail-ej1-x643.google.com with SMTP id bo3so16292398ejb.11 for ; Tue, 25 Aug 2020 05:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XYEs0SeKjvZ6gq7eyQ0Q6adsfDtSQvq1sxT/mG0sLzw=; b=X+DaCrsqja5m9fWQnE4MNpa1HveQpJ9hpUJSeWohnwCHfDtM+Q+Jb7nXUBO5FMawTR LaPxtOg6geE6Ow4cgO1TlsxrXE9ylAVZ9GvcVFrnWupr1280brdjKdtlSEAnapJagUCt v8CBa9oriWC+BGH9+Aw9TNrFu4oFmlgcMUDb8EmwxYMl7kfzxWQ6omqMKkGhFnyhW+EU TlPxDaheHuFqfDkwfY8RTDi8idARjCiPB2l4AlUE2GjfyRpxG2TRz695dMcLdEijcB8K UHHTwD4NXtAphhp0D4qBLivlUjaJMWfw/c/3+bAfsaeOOisTd2aI3Vs6sZ4FKxgE995o 8/Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XYEs0SeKjvZ6gq7eyQ0Q6adsfDtSQvq1sxT/mG0sLzw=; b=PenIFrcxZioPRhPgsQwapnTUaaiPf/2GzwJhk/OcLaQjIQ9iYHTUNCnN1UpTkjzOHt ABVh8dcBfUJ1ps9HIF3eT5NDIdh/U9k+R//R9S1VjHnsOkMXW8eBfXsGuQia6fvC+2IL cjJhzrPQ2ZERl88eqGFpXFOBPWcUJRqeOMR31khz3t84lOiilmFHWO5QtojpWsAeB2Dj 7q36qMdHUB3G1dtmfXFrTqXTe75HJK1SSnswHT/kZlqgTWKqXj3PTMkE2AkPJtgpIq6i LFYrfEkm4bNm5sgglH2uOweRFF5IBDYuPqTBB2Std1qPTHnxsRBQQRZb2paSz63Byiza EAzA== X-Gm-Message-State: AOAM531hI+Oq5RTuy4gKl/eCdCEnRaIGpWOj/Ssxqncg5i3OFqxgYJN1 MsKa84iE/uQ12cWFbjiR+vGnVT8GUAmQbsdxvyPHzw== X-Google-Smtp-Source: ABdhPJwTOCVcymmwr7UFsaiwkiwkN8WdxU7n+QajkSjWT8+0nhNR/CybIlny3nLIkfZrV6rEvtQVCGANpMDGSCGkfFQ= X-Received: by 2002:a17:906:f28b:: with SMTP id gu11mr9998004ejb.407.1598359075171; Tue, 25 Aug 2020 05:37:55 -0700 (PDT) MIME-Version: 1.0 References: <20200825112447.126308-1-kuhn.chenqun@huawei.com> <20200825112447.126308-4-kuhn.chenqun@huawei.com> In-Reply-To: <20200825112447.126308-4-kuhn.chenqun@huawei.com> From: Peter Maydell Date: Tue, 25 Aug 2020 13:37:44 +0100 Message-ID: Subject: Re: [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() To: Chen Qun Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::643; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhanghailiang , QEMU Trivial , Pan Nengyuan , QEMU Developers , qemu-arm , Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 25 Aug 2020 at 12:26, Chen Qun wrote: > > Clang static code analyzer show warning: > target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during its > initialization is never read > TCGv_i64 tcg_rn = new_tmp_a64(s); > ^~~~~~ ~~~~~~~~~~~~~~ > target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' during its > initialization is never read > TCGv_i64 tcg_rd = new_tmp_a64(s); > ^~~~~~ ~~~~~~~~~~~~~~ > > There is a memory leak for the variable new_tmp_a64 "s". There is not, because TCG temps allocated via new_tmp_a64() are all freed via free_tmp_a64() at the end of disas_a64_insn(). > We should delete the assignment. But yes, the assignments are unused and should be deleted. If you fix the commit message, then Reviewed-by: Peter Maydell thanks -- PMM