Re: [PATCH v4 05/30] target/arm: Introduce CPUARMTBFlags

[Peter Maydell <peter.maydell@linaro.org>]

On Fri, 16 Apr 2021 at 20:05, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> In preparation for splitting tb->flags across multiple
> fields, introduce a structure to hold the value(s).
> So far this only migrates the one uint32_t and fixes
> all of the places that require adjustment to match.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/cpu.h           | 26 +++++++++++---------
>  target/arm/translate.h     | 11 +++++++++
>  target/arm/helper.c        | 50 +++++++++++++++++++++-----------------
>  target/arm/translate-a64.c |  2 +-
>  target/arm/translate.c     |  7 +++---
>  5 files changed, 59 insertions(+), 37 deletions(-)

> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 2769e6fd35..9070b773a9 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -12984,8 +12984,9 @@ ARMMMUIdx arm_stage1_mmu_idx(CPUARMState *env)
>  }
>  #endif
>
> -static uint32_t rebuild_hflags_common(CPUARMState *env, int fp_el,
> -                                      ARMMMUIdx mmu_idx, uint32_t flags)
> +static CPUARMTBFlags
> +rebuild_hflags_common(CPUARMState *env, int fp_el,
> +                      ARMMMUIdx mmu_idx, CPUARMTBFlags flags)

QEMU coding style doesn't generally put a newline before the function
name (here and below).

>  {
>      DP_TBFLAG_ANY(flags, FPEXC_EL, fp_el);
>      DP_TBFLAG_ANY(flags, MMUIDX, arm_to_core_mmu_idx(mmu_idx));

> @@ -13228,6 +13232,7 @@ void HELPER(rebuild_hflags_a32_newel)(CPUARMState *env)
>      int el = arm_current_el(env);
>      int fp_el = fp_exception_el(env, el);
>      ARMMMUIdx mmu_idx = arm_mmu_idx_el(env, el);
> +
>      env->hflags = rebuild_hflags_a32(env, fp_el, mmu_idx);
>  }
>

Stray whitespace change.

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM