From: Peter Maydell <peter.maydell@linaro.org>
To: Gavin Shan <gshan@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>, Shan Gavin <shan.gavin@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] target/arm: Initlaize PMU feature for scratch vcpu
Date: Wed, 7 Apr 2021 07:38:32 +0000 [thread overview]
Message-ID: <CAFEAcA_-cmCFDgaqVsZEFT5w56g0LLr3aCzjCf1Od4iov6eWiA@mail.gmail.com> (raw)
In-Reply-To: <20210407040100.9933-2-gshan@redhat.com>
On Wed, 7 Apr 2021 at 03:01, Gavin Shan <gshan@redhat.com> wrote:
>
> If the scratch vCPU is initialized without PMU feature, we receive
> error on reading PMCR_EL0 as it's invisible in this case. It leads
> to host probing failure.
>
> This fixes the issue by initializing the scratch vcpu with the PMU
> feature enabled and reading PMCR_EL0 from host. Otherwise, its value
> is set according to the detected target.
>
> Fixes: f7fb73b8cdd3 ("target/arm: Make number of counters in PMCR follow the CPU")
This commit has been reverted...
I couldn't find a cover letter for these patches, so it's
hard to tell what you're aiming to do with them. Could you
make sure you always send a cover letter with a multiple-patch
series, please ? This also helps with our automated tooling.
thanks
-- PMM
next prev parent reply other threads:[~2021-04-07 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 4:00 [PATCH 1/2] target/arm: Needn't validate the target in scratch host Gavin Shan
2021-04-07 4:01 ` [PATCH 2/2] target/arm: Initlaize PMU feature for scratch vcpu Gavin Shan
2021-04-07 7:38 ` Peter Maydell [this message]
2021-04-12 4:11 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_-cmCFDgaqVsZEFT5w56g0LLr3aCzjCf1Od4iov6eWiA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=gshan@redhat.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).