From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3B0C433B4 for ; Wed, 7 Apr 2021 07:40:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA22A6136A for ; Wed, 7 Apr 2021 07:40:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA22A6136A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU2nR-0007Wx-Th for qemu-devel@archiver.kernel.org; Wed, 07 Apr 2021 03:40:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU2mT-0006fz-3M for qemu-devel@nongnu.org; Wed, 07 Apr 2021 03:39:17 -0400 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:37700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lU2mQ-0006Ul-KY for qemu-devel@nongnu.org; Wed, 07 Apr 2021 03:39:16 -0400 Received: by mail-ej1-x636.google.com with SMTP id w3so26019269ejc.4 for ; Wed, 07 Apr 2021 00:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=15qO1vg8nCc0Pnz1fGixlajvjVxS2/akFygKEONtAk0=; b=LxACFvLWNkjqD4sI6/dYDzEbIetFCjEgurcsq41l46QEsdb04Gz9A/zcLrysZPpMXI bQTSZU4WA/kEmmOHC7f4G3E24K7eGtj2mgXc/CFCzvb9FKDZzzCw759/bPqq52vw1x9B k5LmEaZS+npSFxXlYKYKuehZytc9dHY2ZqSOdI2DWbyQUsNWZ3HtrLPubNLJ/b1qKwry 13Cp98FfEJ3yOdEoNZEL9Px5HAE706hu38e/RQ5+Eh4pTl3W3p2aMaxFEhtae4MTZOtp B+cKHSdOraHQhd1IKSO7M9QZ19u6MB6pZJbp6VmsTGdnErfH1xTpBrlXkj0rrr5Xc+jB sMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=15qO1vg8nCc0Pnz1fGixlajvjVxS2/akFygKEONtAk0=; b=DxnodBQ9Vty90wkmCZvIjbvIuT7/1hjiz+4/5oBmNAiv+zULKMQVbGByD5k/xywfH6 KDe3X3XD3Tk0c2pkNZs3gBqaSBo3h1hsv0pAJK0MYi24JA7MgdBzw5BFB/ss4KVUfydJ 53+GFzRU8E6sHgTs84ghvnpWJHmUuNdPuUGApMuOqdldX9QVWvJaxmuFHztpqLNRnPkg KnnxjU1vLgxV8X7yAPy4tmax16tHgsEtc88ACQD8om8aoVmTwu+gVOiv02iuDG9B/BtX 9TYU46y4237gYGCV0vF2cBu9hyW8rQrzhBvw6QiTcGiTVy1huH3jMdIArvnK13j8hl1j jGUQ== X-Gm-Message-State: AOAM531WzYo7hYZX/YVA+uuGbCVL9eGZxUyJTRPMzBYYmhvep2Q6Bygy xA3ZoPfoe42niwoH9LaqVphLqWBjyDo2jFPJR6DRcw== X-Google-Smtp-Source: ABdhPJwPRvMhDuKciGSzKJC65iAQp03SSVwpakGEvmVIS8ZLiaLlcZl7cn4jZwZAgh+KYIwWMad5nPIEU/6QEnKlIHw= X-Received: by 2002:a17:906:1dd3:: with SMTP id v19mr2222158ejh.4.1617781151928; Wed, 07 Apr 2021 00:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20210407040100.9933-1-gshan@redhat.com> <20210407040100.9933-2-gshan@redhat.com> In-Reply-To: <20210407040100.9933-2-gshan@redhat.com> From: Peter Maydell Date: Wed, 7 Apr 2021 07:38:32 +0000 Message-ID: Subject: Re: [PATCH 2/2] target/arm: Initlaize PMU feature for scratch vcpu To: Gavin Shan Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , QEMU Developers , Marcin Juszkiewicz , qemu-arm , Shan Gavin , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 7 Apr 2021 at 03:01, Gavin Shan wrote: > > If the scratch vCPU is initialized without PMU feature, we receive > error on reading PMCR_EL0 as it's invisible in this case. It leads > to host probing failure. > > This fixes the issue by initializing the scratch vcpu with the PMU > feature enabled and reading PMCR_EL0 from host. Otherwise, its value > is set according to the detected target. > > Fixes: f7fb73b8cdd3 ("target/arm: Make number of counters in PMCR follow the CPU") This commit has been reverted... I couldn't find a cover letter for these patches, so it's hard to tell what you're aiming to do with them. Could you make sure you always send a cover letter with a multiple-patch series, please ? This also helps with our automated tooling. thanks -- PMM